Repository navigation
[TS] Model Array and String operations through EtsIR - #443
Merged
Merged
Conversation
CaelmBleidd
marked this pull request as ready for review
October 2, 2026 16:13
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-numeric-pr391
branch
from
October 2, 2026 16:45
2a9a019 to
22f46c6
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-sequences-pr391
branch
2 times, most recently
from
October 7, 2026 23:02
004570f to
a928cc6
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-numeric-pr391
branch
from
October 7, 2026 23:02
22f46c6 to
5c0f812
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-sequences-pr391
branch
from
October 11, 2026 06:51
a928cc6 to
7903bbd
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-numeric-pr391
branch
2 times, most recently
from
October 12, 2026 13:26
525927c to
d1eb704
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-sequences-pr391
branch
from
October 12, 2026 13:26
7903bbd to
625f41f
Compare
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-numeric-pr391
branch
from
October 12, 2026 14:29
d1eb704 to
1706fa2
Compare
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
Resolved. I addressed the merge conflict in commit |
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-sequences-pr391
branch
from
October 12, 2026 16:47
8c95ba9 to
ff86b66
Compare
This was referenced Oct 12, 2026
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-sequences-pr391
branch
2 times, most recently
from
October 13, 2026 10:14
6f89c12 to
bfa7cb8
Compare
Co-authored-by: CaelmBleidd <31047452+CaelmBleidd@users.noreply.github.com>
CaelmBleidd
force-pushed
the
caelmbleidd/stdlib-sequences-pr391
branch
from
October 13, 2026 19:07
bfa7cb8 to
ac52b31
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String algorithms execute through ordinary EtsIR length, indexing, comparisons, loops and concatenation. UTF-16 reads support bounded symbolic strings and positions, with undefined for invalid or out-of-range indexes. The private length/range-copy intrinsics and unused initial-state callbacks are removed.
Private UTF-16 helper dispatch now checks the exact bundled artifact and class owner, preserving foreign same-named declarations. String and Array builtins ignore semantically unused extra arguments after ordinary source argument evaluation, including Array.pop.
Validation: the earlier published head passed the full local usvm-ts suite (1,190 passed, 142 skipped). The current cleanup passed 62 focused model/source/SDK regressions and detektMain/detektTest. Fresh CI for the current head is the broader gate.
Review focus: artifact identity, meaningful argument slots, canonical string indexes, backing bounds, symbolic search/slicing and sparse-array fallback. ASCII case conversion retains its bounded non-ASCII residual fallback. String-index writes remain outside this published change.
Based on main eb632e9 after #446. Preserve Array.isArray registration alongside the Array/String sequence models. All ten own commits are retained; the conflict changes only catalog expectations. Validation on bfa7cb8: 77 catalog, Array.isArray, sequence and fresh-string tests passed without skips; Detekt main/test passed. Full CI run 38381980353 is running on this exact head.