Repository navigation
Preserve unknown input keys when copying reference-key sets - #474
Merged
Merged
Conversation
Saloed
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copying an input reference-key set could lose its unknown initial entries. Any-key selection then invented an allocated key that was absent from the copied collection, eliminating valid execution paths. Preserve the input-origin marker through both input-to-allocated and input-to-input reference unions, matching the existing primitive-key contract.
Independent fix against main; no Go dependency. Two solver regressions cover direct and repeated copies: selecting an unknown initial source key is SAT, while inventing a key absent from the source is UNSAT.
Validation: ObjectMapTest suite and production/test Detekt pass on final01cba793. Native Go regression validation is separate and still pending; this PR does not claim all Go requests are ready.