Skip to content

Preserve unknown input keys when copying reference-key sets #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CaelmBleidd merged 2 commits into from
Oct 13, 2026
Merged

Preserve unknown input keys when copying reference-key sets #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
14f0f64
Preserve unknown initial keys when copying input reference sets
CaelmBleidd Oct 13, 2026
01cba79
Clarify copied input map regression setup
CaelmBleidd Oct 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions usvm-core/src/main/kotlin/org/usvm/collection/set/ref/USymbolicRefSetUnionAdapter.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,9 +157,8 @@ class UInputToAllocatedSymbolicRefSetUnionAdapter<SetType>(

override fun collectSetElements(elements: USymbolicSetElementsCollector.Elements<UHeapRef>) {
val setElements = USymbolicSetElementsCollector.collect(setOfKeys.updates)
if (setElements.isInput) {
elements.isInput = true
}
// The initial input collection can contain elements absent from its update tree.
elements.isInput = true
setElements.elements.mapTo(elements.elements) { it.second }
}

Expand Down Expand Up @@ -211,9 +210,8 @@ class UInputToInputSymbolicRefSetUnionAdapter<SetType>(

override fun collectSetElements(elements: USymbolicSetElementsCollector.Elements<USymbolicSetElement<UAddressSort>>) {
val setElements = USymbolicSetElementsCollector.collect(setOfKeys.updates)
if (setElements.isInput) {
elements.isInput = true
}
// The initial input collection can contain elements absent from its update tree.
elements.isInput = true
setElements.elements.mapTo(elements.elements) { dstSetRef to it.second }
}

Expand Down
29 changes: 29 additions & 0 deletions usvm-core/src/test/kotlin/org/usvm/api/collections/ObjectMapTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,6 +253,35 @@ class ObjectMapTest : SymbolicCollectionTestBase() {
testMapMerge(symbolicMap0, symbolicMap1)
}

@Test
fun testCopiedInputMapCanSelectAnInitialKey() = testInputCopyRetainsUnknownKey(throughSecondCopy = false)

@Test
fun testRepeatedInputMapCopyCanSelectAnInitialKey() = testInputCopyRetainsUnknownKey(throughSecondCopy = true)

private fun testInputCopyRetainsUnknownKey(throughSecondCopy: Boolean) = scope.doWithState {
val source = ctx.mkRegisterReading(idx = 99, sort = ctx.addressSort)
val firstCopy = mkSymbolicObjectMap(mapType)

symbolicObjectMapMergeInto(firstCopy, source, mapType, ctx.sizeSort)
val copy = if (throughSecondCopy) {
val secondCopy = mkSymbolicObjectMap(mapType)
symbolicObjectMapMergeInto(secondCopy, firstCopy, mapType, ctx.sizeSort)
secondCopy
} else {
firstCopy
}

val selectedKey = symbolicObjectMapAnyKey(copy, mapType)
val sourceContains = symbolicObjectMapContains(source, selectedKey, mapType)
val copyContains = symbolicObjectMapContains(copy, selectedKey, mapType)

checkWithSolver {
assertPossible { mkAnd(mkNot(mkHeapRefEq(source, nullRef)), sourceContains, copyContains) }
assertImpossible { mkAnd(copyContains, mkNot(sourceContains)) }
}
}

@Test
fun testMapRetrieveAnyKey() = scope.doWithState {
callStack.push(method = Any(), returnSite = null)
Expand Down
Loading