Skip to content

Route security reviews to security-audit and test its validators in CI #131

Closed

Description

@YuukiFST

Problem

Found by the review of #130 after its merge:

  • The descriptions of security-review and security-bounty-hunter overlap with security-audit on reviewing and hunting vulnerabilities in a codebase, and none says when another skill applies. "Security review of this endpoint" pulls security-review by name, though that skill is a checklist for writing new code.
  • No CI job runs the security-audit validator tests. The Windows fallback diverges from upstream for good (Read validator input safely on Windows cloudflare/security-audit-skill#69 closed unmerged), so only a manual run catches a mistake when it is applied again after an upstream update.

Acceptance criteria

  • The two ECC descriptions end with a sentence that sends reviews or audits of existing code to security-audit; security-audit stays identical to Omoikane's copy.
  • A CI job runs both validator test files on ubuntu-latest and windows-latest, and passes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions