Repository navigation
fix(skills): route security reviews to security-audit and test its validators - #132
Merged
Merged
Conversation
security-review and security-bounty-hunter overlapped with security-audit on reviewing and hunting in a codebase, and none said when the other applies. A belongs-to sentence in the two ECC descriptions keeps security-audit identical to Omoikane's copy. Refs #131
The Windows fallback never returns upstream, so this job is the only check when it is applied again after an upstream update. Refs #131
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #131
Follow-up to #130, from its review (#130 (review)). These two commits landed on the branch after #130 merged, so they come here.
What changed
skills/security-review/SKILL.mdandskills/security-bounty-hunter/SKILL.md: each description ends with a sentence that sends reviews or audits of existing code tosecurity-audit, the wayai-tellsandai-copywritername each other.security-auditstays identical to Omoikane's copy..github/workflows/ci.yml: new jobsecurity-audit-validators. It runs both validator test files with Node 22 onubuntu-latestandwindows-latest. Ubuntu runs the FIFO and symlink cases that Windows skips, and Windows runs the fallback cases.Why
The three descriptions overlapped on reviewing and hunting in a codebase, and none said when another applies. The Windows fallback diverges from upstream for good, so this job is the only check when it is applied again after an upstream update.
Verification