Skip to content

fix(skills): route security reviews to security-audit and test its validators - #132

Merged
YuukiFST merged 2 commits into
mainfrom
fix/131-security-skill-routing-and-ci
Oct 9, 2026
Merged

YuukiFST merged 2 commits into
mainfrom
fix/131-security-skill-routing-and-ci

Conversation

@YuukiFST

@YuukiFST YuukiFST commented Oct 9, 2026

Copy link
Copy Markdown
Owner

Closes #131

Follow-up to #130, from its review (#130 (review)). These two commits landed on the branch after #130 merged, so they come here.

What changed

  • skills/security-review/SKILL.md and skills/security-bounty-hunter/SKILL.md: each description ends with a sentence that sends reviews or audits of existing code to security-audit, the way ai-tells and ai-copywriter name each other. security-audit stays identical to Omoikane's copy.
  • .github/workflows/ci.yml: new job security-audit-validators. It runs both validator test files with Node 22 on ubuntu-latest and windows-latest. Ubuntu runs the FIFO and symlink cases that Windows skips, and Windows runs the fallback cases.

Why

The three descriptions overlapped on reviewing and hunting in a codebase, and none said when another applies. The Windows fallback diverges from upstream for good, so this job is the only check when it is applied again after an upstream update.

Verification

  • CI on this PR runs the new job on both systems.
  • Locally on Windows 10 (Node 24): 75 tests, 69 pass, 0 fail, 6 skipped.

security-review and security-bounty-hunter overlapped with security-audit on reviewing and hunting in a codebase, and none said when the other applies. A belongs-to sentence in the two ECC descriptions keeps security-audit identical to Omoikane's copy.

Refs #131
The Windows fallback never returns upstream, so this job is the only check when it is applied again after an upstream update.

Refs #131
@YuukiFST
YuukiFST merged commit 595619d into main Oct 9, 2026
6 checks passed
@YuukiFST
YuukiFST deleted the fix/131-security-skill-routing-and-ci branch October 13, 2026 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Route security reviews to security-audit and test its validators in CI

1 participant