Repository navigation
Conversation
|
No actionable comments were generated in the recent review. Walkthrough
Merge Risk:
|
|
Independent review of Contract coverage: Windows template rendering and draft creation remain asserted; Unix exact stable-draft validation replaces obsolete note-generation expectations; branded links and direct updater URLs remain covered. The new negative assertion catches Unix release creation/editing and replacement bodies. Existing workflow tests exercise absent, published, prerelease, duplicate, and API-error drafts. Observed validation:
CI is not yet green: the Rust test job is still running. ESP Diagnostics (Windows) failed during Pester installation because the runner could not find PSGallery; GitHub rejected a job retry while the containing workflow remains in progress. Platform builds depend on those jobs. No integration or published snapshot update has occurred, and this report is not a merge-readiness claim. Release artifacts are unchanged. |
|
CI attempt 1 is terminal and failed. The required
Once attempt 1 completed, the Windows job retry was accepted. Attempt 2 job 126866868323 cleared the PSGallery/Pester setup failure, signing checks, and parser-contract tests; it remains active. The required Rust audit failure is carried forward, so the latest attempt cannot satisfy normal integration gates regardless of the Windows result. This repair changes only |
The daily download snapshot stops in
project-links.test.tsbecause it still expects Unix to render release notes. PR #981 moved that responsibility to Windows, so collection has not reached the GitHub asset counters since October 21.Replace the three stale assertions with the current contract: Windows creates the draft using rendered notes, and Unix validates the exact stable draft without creating or editing release notes. Existing branded-download links and direct updater URL checks remain intact. This changes one test file and no release artifacts or workflows.
Validation:
git diff --checkpasses.After integration, run the existing Download metrics snapshot workflow and verify the published report. Current surviving asset totals can be recovered; missing daily history and final counts for replaced nightly assets cannot be reconstructed.
Summary by CodeRabbit