Repository navigation
Conversation
RUSTSEC-2026-0384: on the multi-threaded runtime, tokio 1.54.0 has a race between Interval::poll_tick and the time driver that can drop a timer entry without synchronization (crashes and use-after-free). 1.54.0 is yanked; the fix is 1.54.1. cargo deny's advisories check fails on it, which fails the required Check & Test (Rust) job on main and every open PR. Lockfile only: tokio's version and checksum. A plain `cargo update -p tokio` with this host's cargo also re-resolved windows-sys for 14 unrelated crates, so only the two tokio lines are changed and `cargo check --locked` confirms the lock is consistent. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
4 of 34 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks the required Check & Test (Rust) job on main and on every open PR. A new advisory, RUSTSEC-2026-0384 (published after 1.6.3), fails its "Supply chain audit (licenses & bans)" step:
cargo deny checkreportsadvisories FAILEDon tokio 1.54.0.The advisory
On the multi-threaded runtime, tokio 1.54.0 has a race between
tokio::time::Interval::poll_tickand the runtime's time driver that can drop an internal timer entry without synchronization, which can lead to crashes and use-after-free.SleepandTimeoutare not affected. Tokio yanked 1.54.0; the fix is 1.54.1 (tokio-rs/tokio#8692).The change
Cargo.lockonly: tokio's version (1.54.0 to 1.54.1) and its checksum, 2 lines. A plaincargo update -p tokio --precise 1.54.1with the local cargo also re-resolvedwindows-sysfor 14 unrelated crates, so that diff was discarded and only the tokio entry was changed.Verification
cargo check --locked(fromsrc-tauri): exit 0, so the lock is consistent as written.cargo deny check advisories(fromsrc-tauri):advisories ok.cargo audit: exit 0.After this merges, each open PR takes main once to pick it up.
🤖 Generated with Claude Code