Skip to content

fix(deps): tokio 1.54.1 for RUSTSEC-2026-0384 - #992

Open
adamgell wants to merge 1 commit into
mainfrom
fix/deps-tokio-rustsec-2026-0384
Open

adamgell wants to merge 1 commit into
mainfrom
fix/deps-tokio-rustsec-2026-0384

Conversation

@adamgell

Copy link
Copy Markdown
Owner

Unblocks the required Check & Test (Rust) job on main and on every open PR. A new advisory, RUSTSEC-2026-0384 (published after 1.6.3), fails its "Supply chain audit (licenses & bans)" step: cargo deny check reports advisories FAILED on tokio 1.54.0.

The advisory

On the multi-threaded runtime, tokio 1.54.0 has a race between tokio::time::Interval::poll_tick and the runtime's time driver that can drop an internal timer entry without synchronization, which can lead to crashes and use-after-free. Sleep and Timeout are not affected. Tokio yanked 1.54.0; the fix is 1.54.1 (tokio-rs/tokio#8692).

The change

Cargo.lock only: tokio's version (1.54.0 to 1.54.1) and its checksum, 2 lines. A plain cargo update -p tokio --precise 1.54.1 with the local cargo also re-resolved windows-sys for 14 unrelated crates, so that diff was discarded and only the tokio entry was changed.

Verification

  • cargo check --locked (from src-tauri): exit 0, so the lock is consistent as written.
  • cargo deny check advisories (from src-tauri): advisories ok.
  • cargo audit: exit 0.

After this merges, each open PR takes main once to pick it up.

🤖 Generated with Claude Code

RUSTSEC-2026-0384: on the multi-threaded runtime, tokio 1.54.0 has a race
between Interval::poll_tick and the time driver that can drop a timer entry
without synchronization (crashes and use-after-free). 1.54.0 is yanked; the
fix is 1.54.1. cargo deny's advisories check fails on it, which fails the
required Check & Test (Rust) job on main and every open PR.

Lockfile only: tokio's version and checksum. A plain `cargo update -p tokio`
with this host's cargo also re-resolved windows-sys for 14 unrelated crates,
so only the two tokio lines are changed and `cargo check --locked` confirms
the lock is consistent.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@github-actions github-actions Bot added bug Something isn't working enhancement New feature or request labels Oct 22, 2026
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock, !Cargo.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@adamgell adamgell mentioned this pull request Oct 22, 2026
4 of 34 tasks

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant