Repository navigation
Fix JavaScript custom bundle compilation - #459
Merged
Merged
Conversation
Prevent customization modules injected into javascript.qll from re-exporting framework libraries and breaking recursive standard-library resolution. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrow import-visibility changes have no identified blocking issues, and targeted tests and custom-bundle compilation are reported passing.
0 open findings
What changed in this PR
Prevents CAP and UI5 customization names from being re-exported through javascript.qll, fixing custom-bundle module-resolution errors while preserving security-query behavior.
Changes:
- Makes customization imports private and removes unnecessary aliases.
- Documents why bundle-injected imports must remain private.
| File | Description |
|---|---|
| javascript/frameworks/ui5/lib/advanced_security/javascript_sap_ui5_all/Customizations.qll | Makes five UI5 customization imports private and explains why. |
| javascript/frameworks/cap/lib/advanced_security/javascript_sap_cap_all/Customizations.qll | Makes the CAP source customization import private and explains why. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Use the upstream summary-model support now available in the current CodeQL libraries. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Add a Linux CI regression job that bundles CAP and UI5 customizations into javascript-all and compiles both dependent query packs. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
mbaluda
changed the title
Prefer CodeQL's canonical package-cache path and retain resolver discovery as a fallback. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Name temporary regression artifacts after the JavaScript custom bundle rather than the library author. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Compile one synthetic query pack against the real customized JavaScript standard library and install only the required JavaScript dependencies. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
data-douser
approved these changes
Oct 16, 2026
mbaluda
added a commit
that referenced
this pull request
Oct 16, 2026
This reverts commit 523024b. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What This PR Contributes
scripts/test-custom-bundle.shto bundle CAP and UI5 customization libraries into the lockedcodeql/javascript-allpack.import javascriptsmoke query withcodeql pack createand no default compilation cache.private importso implementation modules are not re-exported throughjavascript.qll.PatchDataFlowcompatibility layer and uses the summary-model support now provided by the current CodeQL libraries.