Repository navigation
Expand CAP and UI5 analysis - #460
Merged
Merged
Conversation
Keep standard-query sink sharing close to a2a5461 while retaining newer UI5 query models. Clarify CQL value parameterization in query help. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Record the rollback on main without changing the saved feature tree, so the follow-up pull request shows the complete reintroduction of the CAP and UI5 analysis improvements. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Restore client-side URL redirect sink sharing, include UI5 browser sources in regex-injection analysis, and resolve legacy localResources registrations. Add focused tests while retaining control ownership checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Apply conservative metadata barriers and support named/aliased loader factories. Expand request-forgery opt-in coverage and private imports, and fix JSON/JS fixtures. This refresh follows 20 passing focused CodeQL tests and real OpenUI5 1.148.0 browser checks. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Source workflow run: 40503187335 Two intentional new any-property findings are included. Total results: 282. SARIF diff: zero. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
The changes require final human review because they are too complex or risky for automated approval.
No open issues 🎉
1 file not reviewed
javascript/frameworks/ui5/test/queries/UI5Xss/xss-searchfield-jquery-html/package-lock.json: Generated file
Review effort: Balanced
mbaluda
marked this pull request as ready for review
October 27, 2026 13:19
mbaluda
enabled auto-merge (squash)
October 28, 2026 11:15
nicolaswill
approved these changes
Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What This PR Contributes
Reintroduces the CAP and UI5 security-analysis improvements from #456, #450, and #459, while keeping sink sharing with standard queries close to its historical behavior.