fix(ci): route manifest-file per target branch in release-please workflow - #594
Merged
Merged
Conversation
…flow main's workflow always used the default .release-please-manifest.json regardless of target_branch, unlike next's workflow. Dispatching with target_branch=next from main's ref would apply prerelease config against the wrong manifest file and corrupt version state.
|
Looks good - no bugs or correctness issues found. |
sumedhb1995
approved these changes
Jul 7, 2026
This was referenced Jul 7, 2026
1 task
prasad-albert
added a commit
that referenced
this pull request
Jul 8, 2026
main's tags have always been component-less (v1.32.1, not albert-v1.32.1). package-name: albert implicitly set the expected component in manifest mode, which release-please now runs (#594) after config-file/manifest-file became the sole source of release-type/versioning-strategy. That mismatch made release-please reject every historical tag as an unknown component and fall back to a full-history diff (PR #596).
prasad-albert
added a commit
that referenced
this pull request
Jul 8, 2026
main's tags have always been component-less (v1.32.1, not albert-v1.32.1). package-name: albert implicitly set the expected component in manifest mode, which release-please now runs (#594) after config-file/manifest-file became the sole source of release-type/versioning-strategy. That mismatch made release-please reject every historical tag as an unknown component and fall back to a full-history diff (PR #596).
1 task
prasad-albert
added a commit
that referenced
this pull request
Jul 8, 2026
) Reverts #594. Explicitly passing manifest-file (and dropping the release-type/versioning-strategy action inputs) pushed main's release-please run into full manifest-mode component search, which doesn't recognize this repo's component-less tags and produces a full-history diff (see PR #596, #603). Reverting to restore main's release-please run to its previous working behavior while a proper fix for next's manifest routing is worked out separately.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.release-please-manifest.json, ignoringtarget_branch— next's workflow correctly switches manifest-file per target.target_branch=nextfrom main's ref uses.release-please-manifest-next.jsoninstead of silently applying prerelease config against the wrong manifest.Test plan
release-please-config.json/.release-please-manifest.json)release-please-config-next.json/.release-please-manifest-next.json