chore(ci): revert manifest-file routing in release-please workflow - #604
Merged
Merged
Conversation
Reverts #594. Explicitly passing manifest-file (and dropping the release-type/versioning-strategy action inputs) pushed main's release-please run into full manifest-mode component search, which doesn't recognize this repo's component-less tags and produces a full-history diff (see PR #596, #603). Reverting to restore main's release-please run to its previous working behavior while a proper fix for next's manifest routing is worked out separately.
|
Looks good - no bugs or correctness issues found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
manifest-file(and dropping therelease-type/versioning-strategyaction inputs) pushed main's release-please run into full manifest-mode component search. That mode doesn't recognize this repo's component-less tags and produces a full-history diff instead of a normal small release PR (see chore(main): release albert 1.33.0 #596, chore(main): release albert 1.33.0 #603 — both had to be closed).Test plan
release-please--branches--main--components--albert, re-trigger release-please onmain, confirm the new PR only contains real unreleased commits.