Fix bugs and improve default fallback logic of Apache Dubbo adapter - #1680
Merged
Conversation
…ogic for validation Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
added
kind/bug
jasonjoo2010
requested changes
Aug 19, 2020
sczyh30
force-pushed
the
fix-dubbo-27x-adapter-20200819
branch
from
August 20, 2020 01:48
20229fc to
e0280b9
Compare
jasonjoo2010
requested changes
Aug 20, 2020
- Fix NPE bug in consumer filter (when non-biz error occurred) - Improve default fallback in Dubbo 2.7.x adapter: convert the BlockException to a simple RuntimeException (with necessary message) - Polish code and comments Signed-off-by: Eric Zhao <sczyh16@gmail.com>
sczyh30
force-pushed
the
fix-dubbo-27x-adapter-20200819
branch
from
August 20, 2020 02:02
e0280b9 to
02e23d1
Compare
jasonjoo2010
approved these changes
Aug 20, 2020
jasonjoo2010
left a comment
jasonjoo2010
left a comment
Collaborator
There was a problem hiding this comment.
LGTM
There are some unnecessary changes in pr and I suggest we can avoid it in future to keep pr small and simple.
Collaborator
|
Thanks for your contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
There are some problems in Apache Dubbo adapter (since 1.8.0-SNAPSHOT):
This PR fixes the bug and improves the default fallback of Apache Dubbo 2.7.x adapter.
Does this pull request fix one issue?
NONE
Describe how you did it
toRuntimeException) in BlockException and polish logic forBlockExceptionvalidationDescribe how to verify it
Run the test cases.
Special notes for reviews
NONE