Skip to content

The onboarding finale says Tap when the shortcut taps - #1750

Merged
kitlangton merged 1 commit into
devfrom
onboarding-tap-copy
Nov 13, 2026
Merged

kitlangton merged 1 commit into
devfrom
onboarding-tap-copy

Conversation

@kitlangton

@kitlangton kitlangton commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

The finale says Tap when the shortcut taps

Before: if you pick "Use tap to start" during practice, the shortcut switches to Tap, but "Hex is ready" still says "Hold ⌥ anywhere, then talk." and the login line still says "until you hold the key". So the last page teaches the wrong gesture (audit finding 14.3).

After: the Ready page, the practice heading and the login line all follow the saved trigger mode, the same way the mic note under them already did.

ready(caps, matched, …)              ready(caps, toggle, matched, …)
hold_anywhere(caps)  -> "Hold"       hold_anywhere(caps, toggle) -> gesture(toggle)
                                       gesture(true)  = tr("Tap")
                                       gesture(false) = tr("Hold")
login line: "…until you hold the key."   "…until you tap the key." when toggle
  • I added a mac-onboarding-ready-tap scene (and its playground entry) so the Tap-mode page has a fixture.
  • The Russian "Tap" changes from the noun "Нажатие" to the verb "Нажать" so it reads as an instruction in the sentence. It now matches Ukrainian "Натиснути", and General's Hold/Tap control shows the same word.
  • Nothing changes in Hold mode, so no golden changes.
Hold Tap
Light
Dark

Read: src/rune_ui/onboarding_kit/landing.rs (gesture, hold_anywhere), then the callers in first_run.rs.

@kitlangton
kitlangton merged commit 2a6fde4 into dev Nov 13, 2026
4 checks passed
@kitlangton
kitlangton deleted the onboarding-tap-copy branch November 13, 2026 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant