Repository navigation
The onboarding finale says Tap when the shortcut taps - #1750
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The finale says Tap when the shortcut taps
Before: if you pick "Use tap to start" during practice, the shortcut switches to Tap, but "Hex is ready" still says "Hold ⌥ anywhere, then talk." and the login line still says "until you hold the key". So the last page teaches the wrong gesture (audit finding 14.3).
After: the Ready page, the practice heading and the login line all follow the saved trigger mode, the same way the mic note under them already did.
mac-onboarding-ready-tapscene (and its playground entry) so the Tap-mode page has a fixture.Read:
src/rune_ui/onboarding_kit/landing.rs(gesture,hold_anywhere), then the callers infirst_run.rs.