Repository navigation
fix(ui): translate onboarding and the menu bar, unclip meeting retention and Labs' unload menu - #1763
Open
kitlangton wants to merge 3 commits into
Open
kitlangton wants to merge 3 commits into
kitlangton wants to merge 3 commits into
Conversation
…n, fit Labs' unload menu, and show only Reopen when the shortcut fails (t1548)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six fixes from the 3.4.0 UI audit: onboarding and the menu bar now follow the interface language, a meeting's retention no longer gets cut off, Labs' "Unload after" menu fits its card, and a failed shortcut shows only Reopen Hex.
Nothing changes for English speakers except the meeting retention line and the failed-shortcut page. Audit items 1 (still deciding the copy) and 6 (merged in #1750) aren't here.
❌ Before
✅ After
{keys}placeholder each language can place where its grammar wants it.📊 Proof
Meetings: retention on its own line
Labs › Unload model when idle, German, 860×560
The shortcut didn't start
Practice, Chinese
Hex is ready, Chinese
Windows/Linux onboarding, English ("this computer")
The status menu is native AppKit, so it has no scene;
the_menu_follows_the_interface_languagechecks idle, recording (meeting title kept), and update-ready titles in English and Chinese. New tests:the_practice_and_ready_pages_are_translated(zh),a_shortcut_that_did_not_start_shows_only_reopen,unload_after_fits_its_card_in_a_small_translated_window(de, 860×560, last option and focus ring inside the card). Goldens were regenerated on Linux (23 images: the "this computer" privacy line, the meeting retention line, and the reopen page), and I looked at each one.Follow-up, not here: the "Open Hex when your Mac starts?" login row still says "Mac" and "menu bar". It shows only on macOS, so that's correct today, but the copy should change if the row reaches Windows or Linux.
👀 Read:
src/macos_rune/status_item.rs,label()andrelabel(): English keeps the hand-written title-case strings, and every other language uses the window's sentence-case key, with a trailing…added back where macOS expects it.onboarding_kit/landing.rsaround_keyssplits a translated sentence at{keys}. The rest is routine.🔍 Found in the 3.4.0 UI audit · no user reports · stills from
hex app -- --snapChecks run
scripts/check i18n: 26 passedcargo nextest run -E 'test(/rune_ui|i18n/) - test(the_first_run_moves_cleanly)': 485 passedcargo nextest run status_item: 9 passedcargo clippy --locked --all-targets -- -D warnings: cleanmotion_gate::the_first_run_moves_cleanlytimes out locally at 120 s on unchangeddevtoo, so it was left out above