Repository navigation
Add workaround for datetime-local input in firefox+safari - #39261
Merged
Merged
Conversation
bbovenzi
requested review from
ashb,
pierrejeambrun and
ryanahamilton
as code owners
April 25, 2024 15:16
boring-cyborg
Bot
added
area:UI
eladkal
approved these changes
Apr 25, 2024
jedcunningham
pushed a commit
that referenced
this pull request
Apr 26, 2024
(cherry picked from commit 5638bc3)
15 of 56 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use datetime-local to set base dates, but safari and firefox don't fully support it. Instead, we detect the browser and render separate "date" and "time" inputs side-by-side.
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.