Repository navigation
Skip integration tests for new UI only PR. Run docs build only when needed. - #43512
Conversation
|
|
You also need to add "docs-build" as input of the composite Unfortunately GitHub Actions convers unknown variables, inputs etc into empty string 😱 and in this case you have: turns into I opened (it is still opened) a github support request for that around 3 years ago. But I am afraid the ship has sailed - there are far too many workflows that would be broken if they introduce an error on undefined variables in their expression language :( |
potiuk
left a comment
There was a problem hiding this comment.
Nice. Other than the input that needs to be added to the composite workfw - it is a very nice optimisation!
…e attribute for more enhancements.
a2ec4f9 to
54f4784
Compare
|
As per my understanding it seems |
|
Thanks @potiuk for the details. These look like long standing issues and similar ones from 2021 reports below. It looks even |
|
Ok, I had to pass |
…eeded. (apache#43512) * Run only ui tests for PR with new UI only changes. * Revert test change to UI folder. * Skip integration tests for new UI changes only PR. * Build docs only when needed. Move new UI files only test to a separate attribute for more enhancements. * Fix attribute. * Add docs-build to pass it to build. * Add docs-build in ci.yml to pass it. * Fix outputs.
This is a follow-up on #43503 . Following are the changes.
only_new_ui_filesas an attribute that is true when there are any source files and they contain only new UI changes. Sometimes the PR has no source code changes so instead of diff on 2 empty sets this ensures there are source files and changes in new UI folder with no remaining files left. I am thinking of skipping db tests that now run with "always" that takes 2 mins down from 20 mins earlier but is not needed in new UI only PRs.docs-buildflag is not used in the CI configuration causing docs build to always run that is not needed in new UI only PRs that don't change any user facing docs. Sometimes the build runs for an hour or more with intermittent failures and retry. This ensures to build docs only when needed. If there are scenarios where the flag is False with docs required then this could be improved.only_new_ui_filesreturn an empty list so that these tests are skipped for PR with only new UI changes. Each test takes 2 minutes.