Repository navigation
Check for empty list of integration tests before evaluation inside marix that requires a value. - #43546
Merged
Conversation
tirkarthi
force-pushed
the
fix-integration-annotation
branch
from
October 31, 2024 12:06
fe28602 to
c9cd698
Compare
…trix that requires a value.
tirkarthi
force-pushed
the
fix-integration-annotation
branch
from
October 31, 2024 12:07
c9cd698 to
6be83a6
Compare
gopidesupavan
approved these changes
Nov 1, 2024
Member
|
Nice! |
ellisms
pushed a commit
to ellisms/airflow
that referenced
this pull request
Nov 13, 2024
…trix that requires a value. (apache#43546)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When there is a PR with only new UI changes the list of integration tests is empty. The empty list causes annotation error in matrix step. The PR is green with tests that ran but it sends an email notification that PR run failed due to this annotation error causing confusion. Hence add a check before evaluation to execute integration tests only when the list is not empty. This was due to my previous change in #43512
Solution found in dorny/paths-filter#66 (comment)
Ref error : https://github.com/apache/airflow/actions/runs/11610447563?pr=43501