Repository navigation
Deferrable HttpSensor does not move to Triggerer when using response_check - #44557
kandharvishnu wants to merge 7 commits into
Conversation
potiuk
left a comment
potiuk
left a comment
There was a problem hiding this comment.
Pickling in this case is not really acceptable choice:
- security (big NO)
- compatibility (what happens with pickled data when Python version changes (smaller NO - but still no).
|
Hi @kandharvishnu ! |
239f325 to
1eeabdb
Compare
9744848 to
468eb1e
Compare
test cases were pending and completed them now |
| """Raise when there is a timeout on the deferral.""" | ||
|
|
||
|
|
||
| class ResponseCheckFailedException(AirflowException): |
There was a problem hiding this comment.
We should not add it to airflow/exceptions.py but the one in http provider
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions. |
github-actions
Bot
added
the
stale
| :param response: The response object or list of response objects. | ||
| :return: A function that returns response text(s). | ||
| """ | ||
| if isinstance(response, Response): |
There was a problem hiding this comment.
Would it be better to transform the response in a singleton list and then use the logic in the for loop? Then the transformation logic would only need to be implemented once (DRY principle)? Also I see this method is a copy of what is defined in HttpOperator, maybe it's time to move it in dedicated module (or under hook module) so it can be reused across operator and sensor?
5 participants
Closes: #40209
DAG Code:
Task going to Deferrable mode:
Output of the task:
