Repository navigation
Conversation
yuseok89
marked this pull request as ready for review
October 8, 2026 04:06
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #40209
related: #71922
HttpSensor(deferrable=True)with aresponse_checkfalls back to the synchronous poke loop and holds a worker slot for the whole wait. It now defers, and the check runs on the worker after the trigger returns. If the check returnsFalse, the task defers again.Unlike #44557 and #47719, nothing is pickled and the callable never leaves the worker. The trigger returns the response through the existing JSON-based
HttpResponseSerializer, and re-deferring followsS3KeySensorwithcheck_fn.HttpSensorTriggergets aninitial_delayso that a re-deferred trigger waitspoke_intervalbefore its first request. Each deferral also passes the remaining sensor timeout, sotimeoutstill applies overall.Verified with a live Dag
An
HttpSensor(deferrable=True, poke_interval=20)with aresponse_checkthat passes two minutes after the run starts. Before the change the task stayedrunning. After the change it defers, rechecks every 20 seconds, and succeeds once the check passes.Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.