Repository navigation
Conversation
eladkal
reviewed
Mar 13, 2025
# Conflicts: # providers/http/src/airflow/providers/http/sensors/http.py # providers/http/src/airflow/providers/http/triggers/http.py
eladkal
reviewed
Mar 13, 2025
Contributor
Author
|
@eladkal Still need to remove the pickling, probably the check should move so pickling won't be necessary anymore |
dabla
marked this pull request as draft
March 13, 2025 14:23
dabla
marked this pull request as ready for review
April 15, 2025 11:40
Contributor
Author
|
I think this one is ready |
potiuk
reviewed
Apr 27, 2025
subbota19
reviewed
Jul 23, 2025
Contributor
Author
|
Will close this PR as we cannot pass callable's or lambda's to a Trigger as those are not serializable, which is a requirement for Triggers. Applying custom serialization or using third party libraries to attempt it isn't a good idea, Triggerers should be static and thus not contain dynamic code as Triggers must be executed from their serialized form, they don't have access to the Dag file contrary to workers/executors. |
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #40209
DAG Code:
Task going to Deferrable mode:
Output of the task:
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.