Repository navigation
Update DockerSwarmOperator auto_remove to align with DockerOperator - #45745
Merged
Lee-W merged 2 commits intoFeb 10, 2025
Merged
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
Lee-W
reviewed
Jan 22, 2025
niklasr22
force-pushed
the
fix-docker-swarm-operator-auto-remove
branch
from
February 2, 2025 10:05
4b74edf to
1f83742
Compare
Lee-W
reviewed
Feb 3, 2025
Lee-W
left a comment
Lee-W
left a comment
Member
There was a problem hiding this comment.
would it be possible for us to add a unit test for it so that we won't make the same mistake in the future. Thanks!
niklasr22
force-pushed
the
fix-docker-swarm-operator-auto-remove
branch
2 times, most recently
from
February 8, 2025 15:04
e74f315 to
497813f
Compare
niklasr22
requested review from
Fokko,
XD-DENG,
ashb,
bbovenzi,
bolkedebruin,
dstandish,
eladkal,
ephraimbuddy,
hussein-awala,
jedcunningham,
josh-fell,
jscheffl,
kaxil,
o-nikolas,
pierrejeambrun,
potiuk,
ryanahamilton,
uranusjr and
vincbeck
as code owners
February 8, 2025 15:04
niklasr22
force-pushed
the
fix-docker-swarm-operator-auto-remove
branch
2 times, most recently
from
February 8, 2025 15:17
7187d1d to
518dab1
Compare
niklasr22
force-pushed
the
fix-docker-swarm-operator-auto-remove
branch
from
February 8, 2025 15:18
518dab1 to
d098d21
Compare
Contributor
Author
|
sorry for the review request mess... |
Lee-W
approved these changes
Feb 10, 2025
|
Awesome work, congrats on your first merged pull request! You are invited to check our Issue Tracker for additional contributions. |
ambika-garg
pushed a commit
to ambika-garg/airflow
that referenced
this pull request
Feb 17, 2025
…pache#45745) * Update DockerSwarmOperator auto_remove to align with DockerOperator * add docker swarm auto remove test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The description of the auto_remove field didn't match the field types defined in DockerOperator.
Also "success" and "force" currently don't behave as expected.