Repository navigation
Add Create Connection button and form on connection page - #47868
Merged
Merged
Conversation
shubhamraj-git
requested review from
bbovenzi,
jscheffl,
pierrejeambrun and
ryanahamilton
as code owners
March 17, 2025 15:58
shubhamraj-git
force-pushed
the
add_connection
branch
from
March 17, 2025 16:20
4ef5a37 to
10da368
Compare
jscheffl
reviewed
Mar 17, 2025
jscheffl
reviewed
Mar 17, 2025
jscheffl
reviewed
Mar 17, 2025
jscheffl
approved these changes
Mar 17, 2025
jscheffl
left a comment
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
Cool! From my point of view and code-wise this looks good. Just a bit of "Layout nit".
bbovenzi
reviewed
Mar 18, 2025
jscheffl
reviewed
Mar 18, 2025
jscheffl
reviewed
Mar 19, 2025
jscheffl
approved these changes
Mar 19, 2025
jscheffl
left a comment
jscheffl
left a comment
Contributor
There was a problem hiding this comment.
After a small contribution, giving another approval :-D
Contributor
Author
Contributor
|
Cool, you "first self-merged PR"? 🚀 |
agupta01
pushed a commit
to agupta01/airflow
that referenced
this pull request
Mar 21, 2025
* Move useParamStore to common * Foundation work on connection add form * Added Form * Final checks * Reviews * Reviews * Move Extra JSON into Accordion --------- Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
shubham-pyc
pushed a commit
to shubham-pyc/airflow
that referenced
this pull request
Mar 22, 2025
* Move useParamStore to common * Foundation work on connection add form * Added Form * Final checks * Reviews * Reviews * Move Extra JSON into Accordion --------- Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
aaron-y-chen
pushed a commit
to aaron-y-chen/airflow
that referenced
this pull request
Apr 4, 2025
* Move useParamStore to common * Foundation work on connection add form * Added Form * Final checks * Reviews * Reviews * Move Extra JSON into Accordion --------- Co-authored-by: Jens Scheffler <95105677+jscheffl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related: #47496
^ Add meaningful description above
Read the Pull Request Guidelines for more information.
In case of fundamental code changes, an Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in a newsfragment file, named
{pr_number}.significant.rstor{issue_number}.significant.rst, in newsfragments.