Repository navigation
UI: Open provider connection fields by default and title them by connection type - #74273
Merged
Merged
Conversation
…ection type Provider fields declared under conn-fields were grouped in a collapsed "Extra Fields" section, hiding settings such as the Pydantic AI model when creating a connection. The section is now titled after the connection type and opens by default. The accordion renders once the connection type metadata has loaded so the saved extras are not reset when the title changes.
kaxil
marked this pull request as ready for review
October 5, 2026 17:28
kaxil
requested review from
Lee-W,
guan404ming,
henry3260,
jason810496 and
potiuk
as code owners
October 5, 2026 17:28
kaxil
requested review from
BasPH,
ashb,
bbovenzi,
bugraoz93,
choo121600,
hussein-awala,
jscheffl,
mobuchowski,
pierrejeambrun,
romsharon98,
ryanahamilton,
sekikn,
shahar1,
shubhamraj-git,
uranusjr,
vatsrahul1001 and
vincbeck
as code owners
October 5, 2026 17:28
Collaborator
|
I like it. I didn't even realize it was a mandatory field and was confused when I got an error message telling me to populate it. (Maybe it was only mandatory in my scenario 🤷♀️ But I still found it annoying that it was hidden away). |
Contributor
|
Thanks! I think I'll get rid of accordions on any form. This isn't the first time this issue has come up. |
bbovenzi
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fields a provider declares under
conn-fieldsinprovider.yamlwere grouped in a section titled "Extra Fields" that started collapsed. When the setting that defines a connection type lives inextra(the model for Pydantic AI; account and warehouse for Snowflake), creating that connection showed only the optional host and password fields, and the ones that matter sat behind a closed accordion. 39 provider packages declareconn-fields.That section is now titled after the connection type ("Pydantic AI Fields", "Snowflake Fields") and opens by default alongside Standard Fields. "Extra Fields JSON" keeps its name, because it is the raw
extraeditor.The accordion now renders only once the connection type metadata has loaded, and it is keyed on the connection type, so the open-by-default state is applied again when the user switches type. Without that gate, an edit dialog opened right after page load would mount with the type id in the title ("pydanticai Fields"). When the metadata arrived, the section would either stay closed under its new title or, if remounted, reset the store holding the saved extras. While the metadata is pending, Standard Fields had nothing to show anyway, and the type selector already shows a spinner.
Every connection type's provider section now starts open, so the dialog is longer for types with many extras, such as Google Cloud (15 fields). Each section can still be collapsed.
The English wording changed in meaning, so it moves to a new
connectionTypeFieldskey and the oldextraFieldskey is removed from every locale, as the i18n README asks for rephrased strings. Other locales fall back to English until translated.The "Extra Fields" name and the collapsed default go back to the original form in #47868. It reused
FlexibleForm, which needs a section title, and named that section after where the values are stored. Only Standard Fields was listed in the accordion'sdefaultValue. Collapsing the provider fields was never discussed there. The Airflow 2 form rendered provider fields inline with the standard ones.Before (new Pydantic AI connection on
main):After (new connection, after switching type from Snowflake to Pydantic AI):
After (editing an existing connection):