Repository navigation
Improve deadline diagnostics for null DagRun fields - #71767
Merged
vatsrahul1001 merged 6 commits intoSep 9, 2026
Merged
Conversation
boring-cyborg
Bot
added
area:dag-processor
area:deadline-alerts
ColtenOuO
reviewed
Aug 18, 2026
ColtenOuO
left a comment
ColtenOuO
left a comment
Contributor
There was a problem hiding this comment.
Nice work! Thanks for your fix!
I noticed an edge case and noted it in the comment :D
Contributor
|
Can you add a 1-line bugfix newsfragment? Other than that I think this LGTM and I want to get it merged before a handful of others while need to rebase on top of this fix. |
This was referenced Aug 29, 2026
ferruzzi
reviewed
Sep 9, 2026
ferruzzi
reviewed
Sep 9, 2026
ferruzzi
approved these changes
Sep 9, 2026
Contributor
Backport successfully created: v3-3-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
vatsrahul1001
added a commit
that referenced
this pull request
Sep 10, 2026
…) (#72812) * Improve deadline diagnostics for null DagRun fields * Limit null deadline warnings to DagRun timestamp references * Add bugfix newsfragment for deadline diagnostics * Fix deadline diagnostics newsfragment formatting * Fix deadline diagnostics for null DagRun timestamps (cherry picked from commit 0e516c3) Co-authored-by: Vincent Hsiao <124506982+fat-catTW@users.noreply.github.com> Co-authored-by: Rahul Vats <43964496+vatsrahul1001@users.noreply.github.com>
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
* Improve deadline diagnostics for null DagRun fields * Limit null deadline warnings to DagRun timestamp references * Add bugfix newsfragment for deadline diagnostics * Fix deadline diagnostics newsfragment formatting * Fix deadline diagnostics for null DagRun timestamps
1 of 2 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
DagRun-based deadline references can evaluate to
Nonewhen the DagRun exists but the referenced timestamp column is unset, such aslogical_dateon manually triggered runs without-l.Before this change, Airflow treated that
Nonethe same as a missing DagRun and logged a misleading “Could not find DagRun” warning. Deadline creation was then skipped without logging the actual reason, making the configuration hard to diagnose.relates: #71750
Solution
Distinguish a missing DagRun row from a present DagRun with a
NULLreferenced column.When deadline creation is skipped because the reference evaluates to
None, log structured context including the Dag id, run id, deadline alert id, reference type, and the DagRun column required by built-in references.Was generative AI tooling used to co-author this PR?
[X]Yes (please specify the tool below)Generated-by: [Codex] following the guidelines
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.