Repository navigation
Warn when a deadline alert cannot be scheduled for a Dag run - #72518
Closed
DipakMandlik wants to merge 1 commit into
Closed
DipakMandlik wants to merge 1 commit into
DipakMandlik wants to merge 1 commit into
Conversation
A DAGRUN deadline reference evaluates to None whenever the Dag run attribute it reads is unset -- `logical_date` is NULL on runs triggered without one, such as `airflow dags trigger` without `-l` or a run created from another Dag's asset output. The caller then created no Deadline row and logged nothing at all, so the alert simply never fired and an operator had no way to discover why. The only trace was a warning from a lower layer claiming the Dag run could not be found, which is actively misleading: the run exists, it just has no value for the column the reference reads.
Member
|
Closing this. Main already logs a warning when a Dag-run deadline reference evaluates to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A DAGRUN deadline reference evaluates to None whenever the Dag run attribute it reads is unset --
logical_dateis NULL on runs triggered without one, such asairflow dags triggerwithout-lor a run created from another Dag's asset output. The caller then created no Deadline row and logged nothing at all, so the alert simply never fired and an operator had no way to discover why.The only trace was a warning from a lower layer claiming the Dag run could not be found, which is actively misleading: the run exists, it just has no value for the column the reference reads.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.