Repository navigation
Add prek check comparing pnpm.overrides against UI workspace lockfiles and Fixes a pre-existing overrides drift in fab's lockfile that the new check caught. - #72311
Closed
RehanAhmad25 wants to merge 1 commit into
Conversation
…s and Fixes a pre-existing overrides drift in fab's lockfile that the new check caught.
RehanAhmad25
requested review from
amoghrajesh,
ashb,
bugraoz93,
gopidesupavan,
jason810496,
jscheffl,
potiuk and
vincbeck
as code owners
August 31, 2026 04:16
3 tasks
Member
|
Closing this. The "drift" it reports in the FAB provider isn't drift: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Picks up the third item from the follow-up checklist on #72298 : a prek check that compares each UI workspace's
pnpm.overrides(package.json) against theoverrides:block pnpm mirrors into that workspace's pnpm-lock.yaml, and fails with a clear message naming the exact keys that drifted, instead of surfacing asERR_PNPM_LOCKFILE_CONFIG_MISMATCHdeep in a hook log.This does not fix the underlying issue. It doesn't identify why dependabot drops the block on some updates (checklist item 1) and doesn't implement a durable fix (item 2). A grouped dependabot PR that hits the bug will still fail static checks and still need a human to regenerate the lockfile , this only makes that failure legible instead of cryptic. Leaving 1 and 2 open for separate discussion.
While testing this against
main, the check caught a pre-existing drift:providers/fab/.../www/pnpm-lock.yamlcarries amoment-timezoneoverride that was missing frompackage.json'spnpm.overrides(leftover from an oldyarn
resolutionssetup, before this workspace moved to pnpm). Fixed that in this PR since the new check would otherwise fail onmainimmediately.related: #72298
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.