Pin pnpm version for FAB and Edge3 UI so bumps keep security overrides - #72390
Merged
Merged
Conversation
These were the only two pnpm directories in the repo without a `packageManager` field. Without it, Dependabot resolves them with pnpm 11, which no longer reads `pnpm.overrides` from `package.json`. It therefore regenerates `pnpm-lock.yaml` with the `overrides:` block missing entirely, silently dropping the pinned security patches for transitive dependencies and breaking frozen installs for the pnpm 10 that the asset-compilation hooks use. The version matches the one already used everywhere else in the repo.
vincbeck
requested review from
dheerajturaga,
jscheffl and
shubhamraj-git
as code owners
September 1, 2026 19:50
boring-cyborg
Bot
added
area:providers
provider:edge
3 tasks
bbovenzi
approved these changes
Sep 2, 2026
vincbeck
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Sep 9, 2026
Without a `packageManager` field, Dependabot resolves these directories with pnpm 11, which no longer reads `pnpm.overrides` from `package.json`. It regenerates `pnpm-lock.yaml` with the `overrides:` block missing entirely, silently dropping the pinned security patches for transitive dependencies and breaking the frozen installs that the lint and asset-compilation hooks rely on. Two lockfiles on this branch had already lost their overrides that way, so they are restored here with the pinned pnpm. The version matches the one the static checks on this branch already install. Backport of apache#71516 and apache#72390, which pin the same field on main.
vincbeck
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Sep 9, 2026
Without a `packageManager` field, Dependabot resolves these directories with pnpm 11, which no longer reads `pnpm.overrides` from `package.json`. It regenerates `pnpm-lock.yaml` with the `overrides:` block missing entirely, silently dropping the pinned security patches for transitive dependencies and breaking the frozen installs that the lint and asset-compilation hooks rely on. Two lockfiles on this branch had already lost their overrides that way, so they are restored here with the pinned pnpm. The version matches the one the static checks on this branch already install. Backport of apache#71516 and apache#72390, which pin the same field on main.
vincbeck
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Sep 9, 2026
Without a `packageManager` field, Dependabot resolves these directories with pnpm 11, which no longer reads `pnpm.overrides` from `package.json`. It regenerates `pnpm-lock.yaml` with the `overrides:` block missing entirely, silently dropping the pinned security patches for transitive dependencies and breaking the frozen installs that the lint and asset-compilation hooks rely on. Two lockfiles on this branch had already lost their overrides that way, so they are restored here with the pinned pnpm. The version matches the one the static checks on this branch already install. Backport of apache#71516 and apache#72390, which pin the same field on main.
vincbeck
added a commit
to aws-mwaa/upstream-to-airflow
that referenced
this pull request
Sep 9, 2026
Without a `packageManager` field, Dependabot resolves these directories with pnpm 11, which no longer reads `pnpm.overrides` from `package.json`. It regenerates `pnpm-lock.yaml` with the `overrides:` block missing entirely, silently dropping the pinned security patches for transitive dependencies and breaking the frozen installs that the lint and asset-compilation hooks rely on. Two lockfiles on this branch had already lost their overrides that way, so they are restored here with the pinned pnpm. The version matches the one the static checks on this branch already install. Backport of apache#71516 and apache#72390, which pin the same field on main.
1 task
bbovenzi
pushed a commit
that referenced
this pull request
Sep 9, 2026
…#72816) Without a `packageManager` field, Dependabot resolves these directories with pnpm 11, which no longer reads `pnpm.overrides` from `package.json`. It regenerates `pnpm-lock.yaml` with the `overrides:` block missing entirely, silently dropping the pinned security patches for transitive dependencies and breaking the frozen installs that the lint and asset-compilation hooks rely on. Two lockfiles on this branch had already lost their overrides that way, so they are restored here with the pinned pnpm. The version matches the one the static checks on this branch already install. Backport of #71516 and #72390, which pin the same field on main.
imrichardwu
pushed a commit
to imrichardwu/airflow
that referenced
this pull request
Sep 11, 2026
apache#72390) These were the only two pnpm directories in the repo without a `packageManager` field. Without it, Dependabot resolves them with pnpm 11, which no longer reads `pnpm.overrides` from `package.json`. It therefore regenerates `pnpm-lock.yaml` with the `overrides:` block missing entirely, silently dropping the pinned security patches for transitive dependencies and breaking frozen installs for the pnpm 10 that the asset-compilation hooks use. The version matches the one already used everywhere else in the repo.
1 task done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These were the only two pnpm directories in the repo without a
packageManagerfield. Without it, Dependabot resolves them with pnpm 11, which no longer readspnpm.overridesfrompackage.json. It therefore regeneratespnpm-lock.yamlwith theoverrides:block missing entirely, silently dropping the pinned security patches for transitive dependencies and breaking frozen installs for the pnpm 10 that the asset-compilation hooks use.The version matches the one already used everywhere else in the repo.
Was generative AI tooling used to co-author this PR?
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.