Repository navigation
Keep the Dag trigger button one-click when a run has no config - #74039
Merged
Merged
Conversation
boring-cyborg
Bot
added
area:translations
area:UI
pierrejeambrun
marked this pull request as ready for review
October 1, 2026 14:20
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 1, 2026 14:20
1 task done
pierrejeambrun
force-pushed
the
trigger-dag-split-button
branch
from
October 1, 2026 14:37
dd4956b to
ef19da4
Compare
bbovenzi
requested changes
Oct 1, 2026
1 task done
bbovenzi
approved these changes
Oct 2, 2026
Contributor
|
Need to rebase |
pierrejeambrun
force-pushed
the
trigger-dag-split-button
branch
from
October 2, 2026 15:42
02c0f53 to
7e5f26c
Compare
Selecting a run that carried a config turned the whole Trigger button into a dropdown, costing an extra click on the most common action. The trigger should stay a single click; re-using a run's config is the rare case and belongs behind a caret that does not slow down the common one.
pierrejeambrun
force-pushed
the
trigger-dag-split-button
branch
from
October 5, 2026 09:06
7e5f26c to
cc32e42
Compare
pierrejeambrun
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the issue
On a Dag/run view, once you select a run that was triggered with a config, the Trigger button turned into a dropdown menu: a single click no longer triggered a run, it just opened a menu, so triggering always cost an extra click (reported in #73177). Triggering a run is the common action; reusing a previous run's config is the rare one, so the common path should not pay for the rare one.
The change
Restores the one-click trigger as a GitHub-style split button. The main button always opens the trigger form in a single click. When the selected run carried a config, a caret appears next to it (and only then) with two options:
When no config run is selected, the button looks and behaves exactly as before.
Also fixes the menu-trigger tooltip: it rendered inline, so a sticky pane header painted over it. It is now portalled and floats above (this fixes every
Menu.Roottooltip, not just this one).Screenshots
closes: #73177
related: #69820
Independent implementation of the UX requested in the issue. It takes the same split-button direction as the draft in #73564, differing in that the main action stays a single click, the caret appears only when the selected run carried a config, and the menu offers a direct modal-bypassing re-trigger alongside the edit-and-trigger form.
Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines
🤖 Generated with Claude Code