Repository navigation
Treat an empty Dag run config as no config in the UI - #74083
Merged
Merged
Conversation
A Dag run triggered without a config comes back from the API as an empty
object `{}`, not null or undefined, so presence checks that compared against
`undefined` treated those runs as if they carried a config: the trigger
button opened a config menu and the run details showed `{}` for runs that
had none. Check for a non-empty object instead, through a shared helper so
every config-presence site agrees.
1 task done
pierrejeambrun
marked this pull request as ready for review
October 2, 2026 10:57
pierrejeambrun
requested review from
bbovenzi,
choo121600,
guan404ming,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
October 2, 2026 10:57
Member
Author
AfterScreen.Recording.2026-10-02.at.12.59.16.mov |
bbovenzi
approved these changes
Oct 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was the issue
A Dag run triggered without a config comes back from the API as an empty object
{}, notnullorundefined. The UI decided "does this run have a config?" by comparing againstundefined, so a configless run was treated as if it had one:Conf: {}for them.Raised in a review comment on #74039.
The change
A small shared type guard
hasDagRunConfig(conf)that treatsnull,undefined, and{}as "no config", used at every config-presence site so they agree:TriggerDAGButton— the menu now appears only for runs with a real config (the fix).Run/Details— theConfrow is empty for configless runs instead of showing{}.DagRunstable — switched its existing inline empty-object check to the same helper (behaviour unchanged).Screenshots
Trigger button — configless run opens the form in one click; a run with config still gets the options menu:
{}) → form opens directlyRun Details
Confrow — empty for a configless run, JSON for a run with config:{}) → noConfvalueThis overlaps the
TriggerDAGButtonarea of #74039 and will conflict with it once one of them merges; that is expected and fine (the config-presence check is the shared piece).Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 4.8) following the guidelines
🤖 Generated with Claude Code