Repository navigation
Conversation
…nvenience method for iterating list_* requests
Contributor
Author
|
Closing in favour of #7598 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SageMakerHook currently does not support any list_* operations (there are a few... https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sagemaker.html). This PR adds a generic method for iterating over list_* operation results and one implementation for list_training_jobs.
By default, boto3 caps the number of results to 10. This is configurable up to 100. I've implemented
_list_requestas a convenience function for making multiple requests to AWS in case more results are available.SageMakerHook.list_training_jobs()makes use of this convenience function.Not sure if tests should be added because all existing SageMakerHook tests simply test the number of calls to the underlying client's methods, which doesn't really validate correct behaviour IMO?
Example usage:
Say there are 2000 training jobs, then
_list_request()will select 150 training jobs in 2 batches (first 100, next 50).Issue link: AIRFLOW-6882
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.