Repository navigation
Conversation
…nvenience method for iterating list_* requests
Codecov Report
@@ Coverage Diff @@
## master #7598 +/- ##
==========================================
- Coverage 86.82% 86.53% -0.29%
==========================================
Files 891 896 +5
Lines 42095 42740 +645
==========================================
+ Hits 36549 36986 +437
- Misses 5546 5754 +208
Continue to review full report at Codecov.
|
6 tasks done
kaxil
approved these changes
Mar 12, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The SageMakerTrainingOperator is currently not idempotent. AWS requires training jobs to have unique names, and training jobs cannot be deleted/updated. Rerunning a SageMakerTrainingOperator will currently raise an exception because it cannot create a training job with the same name.
Therefore I suggest to add an argument
action_if_job_exists, which determines the behaviour in case the training job name already exists. Possible options areincrement(default) andfail, where increment lists all training jobs prefixed with the given name and suffixes the name with length+1:Rerunning will result in training job names:
mytrainingjob
mytrainingjob-2
mytrainingjob-3
....
(the training job name is returned - and thus in an XCom, so users can fetch the updated training job name in a successive task)
The
failmode will simply fail if a training job with the same name is encountered.Additionally, this PR implements a generic method
_list_requeston the SageMakerHook, for performing list operations on boto3. All boto3list_*methods follow the same structure and_list_requestprovides an easy interface to iteratively fetch all results (since AWS returns results in batches).Issue link: AIRFLOW-6884
Make sure to mark the boxes below before creating PR: [x]
[AIRFLOW-NNNN]. AIRFLOW-NNNN = JIRA ID** For document-only changes commit message can start with
[AIRFLOW-XXXX].In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.
Read the Pull Request Guidelines for more information.