Repository navigation
TypeScript SDK: take the task state store retention in seconds - #75445
Merged
Merged
Conversation
retentionMs was the one duration in the SDK that was not seconds, next to executionTimeout, retryDelay and dagrunTimeout, which all are. Rename it to retentionSeconds so every duration carries the same unit. The HITL example modules now export their Dags, so another bundle can serve them. Co-Authored-By: Claude <noreply@anthropic.com>
jason810496
marked this pull request as ready for review
October 23, 2026 06:26
jason810496
requested review from
guan404ming,
henry3260,
pierrejeambrun and
uranusjr
October 23, 2026 09:30
uranusjr
reviewed
Oct 23, 2026
Importing them would run the module-level serve() call, so the importing bundle's own serve() would then fail. Co-Authored-By: Claude <noreply@anthropic.com>
jason810496
commented
Oct 23, 2026
jason810496
left a comment
jason810496
left a comment
Member
Author
There was a problem hiding this comment.
Thanks for the review.
uranusjr
reviewed
Oct 23, 2026
uranusjr
reviewed
Oct 23, 2026
uranusjr
reviewed
Oct 23, 2026
Every other public duration is a bare name in seconds, and the Python argument is retention too. Co-Authored-By: Claude <noreply@anthropic.com>
The caller passes seconds, so the error now uses the same unit. Co-Authored-By: Claude <noreply@anthropic.com>
The task state store section links to it instead of carrying the rule. Co-Authored-By: Claude <noreply@anthropic.com>
Every duration in the SDK is now a bare name in seconds, as defer's timeout is in Python. Co-Authored-By: Claude <noreply@anthropic.com>
jason810496
commented
Oct 23, 2026
jason810496
left a comment
jason810496
left a comment
Member
Author
There was a problem hiding this comment.
Thanks for the review, I remove the time unit suffix for those arguments on TS side that are inconsistent with the Python side.
Contributor
Backport successfully created: v3-4-testNote: As of Merging PRs targeted for Airflow 3.X In matter of doubt please ask in #release-management Slack channel.
|
jason810496
added a commit
that referenced
this pull request
Oct 23, 2026
…conds (#75445) (#75460) * TypeScript SDK: take the task state store retention in seconds retentionMs was the one duration in the SDK that was not seconds, next to executionTimeout, retryDelay and dagrunTimeout, which all are. Rename it to retentionSeconds so every duration carries the same unit. The HITL example modules now export their Dags, so another bundle can serve them. * TypeScript SDK: keep the HITL example Dags unexported Importing them would run the module-level serve() call, so the importing bundle's own serve() would then fail. * TypeScript SDK: name the task state store option retention Every other public duration is a bare name in seconds, and the Python argument is retention too. * TypeScript SDK: report an overflowing retention in seconds The caller passes seconds, so the error now uses the same unit. * TypeScript SDK docs: state the seconds rule once in a Durations section The task state store section links to it instead of carrying the rule. * TypeScript SDK: name the operator timeout option timeout Every duration in the SDK is now a bare name in seconds, as defer's timeout is in Python. --------- (cherry picked from commit ccbd215) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Final nit before the TypeScript SDK beta release.
Every duration is now seconds
retentionMswas the one duration in the SDK that was not seconds, next toexecutionTimeout,retryDelayanddagrunTimeout, which all are. A reader wholearned milliseconds from it would write
executionTimeout: 30_000and get 8.3hours. It is now
retention, a bare name like those options and the Python argument.NEVER_EXPIREis unchanged.Was generative AI tooling used to co-author this PR?
Generated-by: Claude Code (Opus 5.5) following the guidelines