Repository navigation
[v3-4-test] TypeScript SDK: take the task state store retention in seconds (#75445) - #75460
Merged
Merged
Conversation
…conds (#75445) * TypeScript SDK: take the task state store retention in seconds retentionMs was the one duration in the SDK that was not seconds, next to executionTimeout, retryDelay and dagrunTimeout, which all are. Rename it to retentionSeconds so every duration carries the same unit. The HITL example modules now export their Dags, so another bundle can serve them. * TypeScript SDK: keep the HITL example Dags unexported Importing them would run the module-level serve() call, so the importing bundle's own serve() would then fail. * TypeScript SDK: name the task state store option retention Every other public duration is a bare name in seconds, and the Python argument is retention too. * TypeScript SDK: report an overflowing retention in seconds The caller passes seconds, so the error now uses the same unit. * TypeScript SDK docs: state the seconds rule once in a Durations section The task state store section links to it instead of carrying the rule. * TypeScript SDK: name the operator timeout option timeout Every duration in the SDK is now a bare name in seconds, as defer's timeout is in Python. --------- (cherry picked from commit ccbd215) Co-authored-by: Jason(Zhe-You) Liu <68415893+jason810496@users.noreply.github.com>
jason810496
approved these changes
Oct 23, 2026
Contributor
Author
|
Hi maintainer, this PR was merged without a milestone set.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retentionMs was the one duration in the SDK that was not seconds, next to
executionTimeout, retryDelay and dagrunTimeout, which all are. Rename it to
retentionSeconds so every duration carries the same unit.
The HITL example modules now export their Dags, so another bundle can serve
them.
Importing them would run the module-level serve() call, so the importing
bundle's own serve() would then fail.
Every other public duration is a bare name in seconds, and the Python
argument is retention too.
The caller passes seconds, so the error now uses the same unit.
The task state store section links to it instead of carrying the rule.
Every duration in the SDK is now a bare name in seconds, as defer's
timeout is in Python.
(cherry picked from commit ccbd215)
Co-authored-by: Jason(Zhe-You) Liu 68415893+jason810496@users.noreply.github.com