[MNG-7559] Improve documentation of versions comparison - #331
Merged
Merged
Conversation
sultan
force-pushed
the
version-ordering
branch
from
November 6, 2022 11:32
d014203 to
06c0c64
Compare
sultan
marked this pull request as ready for review
November 6, 2022 11:35
sultan
marked this pull request as draft
November 6, 2022 15:12
sultan
force-pushed
the
version-ordering
branch
from
November 6, 2022 16:48
b8c7c7a to
bf0ef6d
Compare
sultan
marked this pull request as ready for review
November 6, 2022 16:56
sultan
marked this pull request as draft
November 12, 2022 20:12
sultan
force-pushed
the
version-ordering
branch
5 times, most recently
from
November 12, 2022 21:07
34e13ad to
1f8296b
Compare
sultan
marked this pull request as ready for review
November 12, 2022 21:08
6 of 8 tasks
Contributor
Author
|
code: documentation: |
Contributor
Author
|
elharo
reviewed
Nov 13, 2022
elharo
left a comment
Contributor
There was a problem hiding this comment.
It would be helpful to separate formatting and language changes from functionality changes.
sultan
force-pushed
the
version-ordering
branch
3 times, most recently
from
November 13, 2022 13:15
8422aa5 to
a7a43ed
Compare
Contributor
Author
|
reverted one comparison, and added another test case to prove website documentation right |
elharo
reviewed
Nov 13, 2022
sultan
force-pushed
the
version-ordering
branch
from
November 13, 2022 13:37
a7a43ed to
040c1dd
Compare
Contributor
Author
|
i think i resolved everything, thank you for your feedback. waiting approval of last fixes. |
Contributor
Author
The test cases for MNG 7559 are here: maven-artifact/src/test/java/org/apache/maven/artifact/versioning/ComparableVersionTest.java of all the error cases 2.3-pfd was the first declared on the issue and fixed. did i miss something ? |
elharo
reviewed
Nov 13, 2022
sultan
force-pushed
the
version-ordering
branch
from
November 13, 2022 15:01
040c1dd to
fb4182c
Compare
sultan
force-pushed
the
version-ordering
branch
from
November 13, 2022 15:30
fb4182c to
d9f8b63
Compare
elharo
approved these changes
Nov 14, 2022
6 of 9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix versions comparison https://issues.apache.org/jira/browse/MNG-7559
intention is:
following semver rules should be encouraged, natural ordering is used without the need to hard code strings, except for hard coded qualifiers 'a', 'b', 'm', 'cr', 'snapshot', 'final', 'ga', 'release', '' and 'sp':
the documentation should discourage the usage of 'CR', 'final', 'ga', 'release' and 'SP' qualifiers.
Maven Central should begin to reject new artifact using CR and SP qualifiers.