[MNG-7559] Fix versions comparison by sultan · Pull Request #845 · apache/maven

sultan · 2022-10-22T15:37:04Z

Fix versions comparison https://issues.apache.org/jira/browse/MNG-7559
intention is:

1.0.0.RC1 < 1.0.0-RC2
( edr, pfd, etc.) < final, ga, release
9.4.1.jre16 > 9.4.1.jre16-preview

following semver rules should be encouraged, natural ordering is used without the need to hard code strings, except for hard coded qualifiers 'a', 'b', 'm', 'cr', 'snapshot', 'final', 'ga', 'release', '' and 'sp':

alpha = a < beta = b < milestone = m < rc = cr < 'snapshot' < '' = 'final' = 'ga' = 'release' < 'sp'

the documentation should discourage the usage of 'CR', 'final', 'ga', 'release' and 'SP' qualifiers.
Maven Central should begin to reject new artifact using CR and SP qualifiers.

Following this checklist to help us incorporate your
contribution quickly and easily:

Make sure there is a JIRA issue filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
Each commit in the pull request should have a meaningful subject line and body.
Format the pull request title like [MNG-XXX] SUMMARY, where you replace MNG-XXX
and SUMMARY with the appropriate JIRA issue. Best practice is to use the JIRA issue
title in the pull request title and in the first line of the commit message.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Run mvn clean verify to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.

sultan · 2022-11-06T12:23:14Z

made the items attribute private with a public getter to respect the code standard

sultan · 2022-11-06T14:43:26Z

added regression test cases

sultan · 2022-11-12T21:09:31Z

code:

PR [MNG-7559] Fix versions comparison #845

documentation:

PR [MNG-7559] Improve documentation of versions comparison maven-site#331

sultan · 2022-11-12T21:28:08Z

I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004

sultan · 2022-11-13T13:28:30Z

added another test case to prove website documentation right

sultan · 2022-11-13T13:55:46Z

code and documentation on par. waiting for final reviews.

elharo

I'm still digging into the other PRs and the existing spec and code. Pleas ebear with me. It's been a while since I looked at this, and I need to make sure all the fiddly little bits are straight in my head.

elharo

Check the output of the CI. The test failures look related.

sultan · 2022-11-14T13:10:56Z

made 3 changes.

javadoc without the last dot
put back a method that returns a string
fixed test, hopefully

sultan · 2022-11-29T12:10:20Z

@elharo, rebased and applied code styles with spotless plugin

rereviewing

elharo

Looks good, just some doc nits

sultan · 2022-11-29T13:04:22Z

made the suggested change, thanks @elharo

sultan · 2022-11-29T14:01:45Z

@elharo, fixed javadoc build errors by replacing > with > and < with <

elharo · 2022-12-03T18:27:11Z

All looks good. I need to copy the PR into my account to run it through Jenkins

elharo · 2022-12-03T19:34:12Z

Jenkins passed my fork of this so I'm going to merge.

https://ci-maven.apache.org/job/Maven/job/maven-box/job/maven/job/MNG-7559/

sultan · 2022-12-16T19:52:31Z

@elharo is it wished to port this to 3.9.x branch? if so a PR is available here:

PR [MNG-7559] Fix versions comparison, backport to 3.9.x #887

elharo · 2022-12-16T20:13:55Z

Check on the dev mailing list and see of anyone is planning another 3.9 release.

This reverts commit 97e8bf6.

michael-o · 2022-12-19T21:48:52Z

This merge has been reverted on master.

sultan · 2022-12-20T12:50:11Z

This merge has been reverted on master.

A new clean PR was created to reintroduce the fix

PR [MNG-7559] Fix version comparison (master 4.0.x branch) #929

jira-importer · 2025-07-07T08:04:58Z

Resolve #8891

michael-o reviewed Oct 22, 2022

View reviewed changes

Comment thread maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java

Comment thread maven-artifact/src/main/java/org/apache/maven/artifact/versioning/ComparableVersion.java Outdated

sultan changed the title ~~Fix versions comparison~~ |MNG-7559] Fix versions comparison Oct 22, 2022

sultan changed the title ~~|MNG-7559] Fix versions comparison~~ [MNG-7559] Fix versions comparison Oct 22, 2022

sultan force-pushed the comparison branch 2 times, most recently from 194316a to 9372f04 Compare October 22, 2022 18:35

sultan force-pushed the comparison branch from e5ed0a6 to b47e889 Compare November 6, 2022 11:30

sultan marked this pull request as ready for review November 6, 2022 11:35

sultan mentioned this pull request Nov 6, 2022

display-dependency-updates version comparison algorithm bug for -pfd mojohaus/versions#744

Closed

sultan force-pushed the comparison branch from b47e889 to 1d41ee3 Compare November 6, 2022 12:20

sultan marked this pull request as draft November 6, 2022 12:28

sultan force-pushed the comparison branch 2 times, most recently from 83a0828 to 8e382dd Compare November 6, 2022 14:42

sultan marked this pull request as ready for review November 6, 2022 14:43

sultan marked this pull request as draft November 6, 2022 15:12

sultan force-pushed the comparison branch from 08078b0 to 9fff42a Compare November 6, 2022 16:42

sultan marked this pull request as ready for review November 6, 2022 16:56

sultan marked this pull request as draft November 12, 2022 20:12

sultan force-pushed the comparison branch from e8b1524 to eb3e293 Compare November 12, 2022 20:24

sultan marked this pull request as ready for review November 12, 2022 21:08

sultan mentioned this pull request Nov 12, 2022

[MNG-7559] Improve documentation of versions comparison apache/maven-site#331

Merged

sultan force-pushed the comparison branch 2 times, most recently from e467f85 to 9b33d69 Compare November 13, 2022 13:16

elharo reviewed Nov 13, 2022

View reviewed changes

sultan force-pushed the comparison branch from 9b33d69 to e2acda8 Compare November 13, 2022 14:38

elharo previously requested changes Nov 14, 2022

View reviewed changes

sultan force-pushed the comparison branch from 758dde5 to 7455563 Compare November 14, 2022 13:07

sultan force-pushed the comparison branch from 7455563 to 70fa20a Compare November 29, 2022 11:47

sultan requested a review from elharo November 29, 2022 12:13

sultan force-pushed the comparison branch 2 times, most recently from 7b078b3 to 8bd408c Compare November 29, 2022 12:39

elharo reviewed Nov 29, 2022

View reviewed changes

sultan force-pushed the comparison branch from 8bd408c to 97f1918 Compare November 29, 2022 13:01

fix version comparison

263cb9f

sultan force-pushed the comparison branch from 97f1918 to 263cb9f Compare November 29, 2022 13:59

elharo approved these changes Nov 29, 2022

View reviewed changes

slachiewicz approved these changes Nov 29, 2022

View reviewed changes

elharo mentioned this pull request Dec 3, 2022

fix version comparison #899

Closed

elharo merged commit 97e8bf6 into apache:master Dec 3, 2022

gnodet added this to the 4.0.0-alpha-3 milestone Dec 5, 2022

sultan mentioned this pull request Dec 16, 2022

[MNG-7559] Fix versions comparison, backport to 3.9.x #887

Closed

6 of 8 tasks

asfgit pushed a commit that referenced this pull request Dec 19, 2022

Revert "fix version comparison (#845)"

29e7b0e

This reverts commit 97e8bf6.

jira-importer mentioned this pull request Mar 1, 2023

[MNG-7559] ComparableVersion vs versions with custom qualifiers #8891

Closed

Conversation

sultan commented Oct 22, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sultan commented Nov 6, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sultan commented Nov 6, 2022

Uh oh!

sultan commented Nov 12, 2022

Uh oh!

sultan commented Nov 12, 2022

Uh oh!

sultan commented Nov 13, 2022

Uh oh!

sultan commented Nov 13, 2022

Uh oh!

elharo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

elharo left a comment

Choose a reason for hiding this comment

Uh oh!

sultan commented Nov 14, 2022

Uh oh!

sultan commented Nov 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elharo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sultan commented Nov 29, 2022

Uh oh!

sultan commented Nov 29, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

elharo commented Dec 3, 2022

Uh oh!

elharo commented Dec 3, 2022

Uh oh!

sultan commented Dec 16, 2022

Uh oh!

elharo commented Dec 16, 2022

Uh oh!

michael-o commented Dec 19, 2022

Uh oh!

sultan commented Dec 20, 2022

Uh oh!

jira-importer commented Jul 7, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

sultan commented Oct 22, 2022 •

edited

Loading

sultan commented Nov 6, 2022 •

edited

Loading

sultan commented Nov 29, 2022 •

edited

Loading

sultan commented Nov 29, 2022 •

edited

Loading