Repository navigation
docs(docker): drop redundant packages from custom image example, bump version numbers - #44240
Merged
sfirke merged 6 commits intoOct 22, 2026
Merged
Conversation
openpyxl ships in every image via pandas[excel] (since 5.0.0) and Pillow has been a core dependency since 6.0.0, so layering them in the example Dockerfile is a no-op. Also correct the -dev preset and tag descriptions: CI builds them with INCLUDE_CHROMIUM=false, so they do not include a headless browser. Point to --build-arg INCLUDE_CHROMIUM=true for dev builds that need one. Point version examples at 7.0.0, the first release with the superset/lean tag naming, and note that 6.1.0 and earlier publish the minimal image under the plain tag with no -lean tag.
Contributor
|
Bito Review Skipped - Source Branch Not Found |
✅ Deploy Preview for superset-docs-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
![codeant-ai-for-open-source[bot]](https://avatars.githubusercontent.com/u/151810221?s=60&v=4){kind=small}
Contributor
|
The review comment is correct. The documentation currently uses docs/admin_docs/installation/docker-builds.mdx |
sfirke
force-pushed
the
docs/docker-builds-drop-redundant-packages
branch
from
September 14, 2026 15:34
78ece9f to
5d2946c
Compare
openpyxl ships in every image via pandas[excel] (since 5.0.0) and Pillow has been a core dependency since 6.0.0, so layering them in the example Dockerfile is a no-op. Also correct the -dev preset and tag descriptions: CI builds them with INCLUDE_CHROMIUM=false, so they do not include a headless browser. Point to --build-arg INCLUDE_CHROMIUM=true for dev builds that need one. Point version examples at 7.0.0, the first release with the superset/lean tag naming, in both the docs and the UPDATING.md entry, and note that for earlier releases the plain tag is the minimal image and any -lean tag for them is that same image. The example Dockerfile builds from 7.0.0-lean instead of master-lean. Replace the Playwright comments in the example, which referred to the removed PLAYWRIGHT_REPORTS_AND_THUMBNAILS flag and to Selenium, with a note that Playwright with Chromium is required as of 7.0.0.
sfirke
force-pushed
the
docs/docker-builds-drop-redundant-packages
branch
from
September 14, 2026 15:44
5d2946c to
ff73677
Compare
This was referenced Sep 14, 2026
The example Dockerfile no longer mentions a feature flag, so the intro sentence pointing readers to one is inaccurate.
github-actions
Bot
added
the
requires:rebase
Resolve docker-builds.mdx conflicts with master's publishing-policy rewrite (apache#44250, apache#44125): keep master's new structure and Showtime/standalone-image notes, and reapply this branch's 7.0.0 version examples and corrected -dev image (no headless browser) wording. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KnpZfSkuBkn5D3wk1SBTCm
github-actions
Bot
removed
the
requires:rebase
9 tasks
Member
Author
|
@rusackas could I get a review on this? For the 7.0.0 docs. |
Contributor
CodeAnt PR Risk: Low Risk
Assessed commit: |
villebro
approved these changes
Oct 22, 2026
villebro
left a comment
villebro
left a comment
Member
There was a problem hiding this comment.
Looks accurate, thanks for the cleanup!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
The main reason I opened this change:
openpyxlships in every image viapandas[excel](since 5.0.0) andPillowhas been a core dependency since 6.0.0, so layering them in the example Dockerfile is a no-op. These are no longer needed.While there, I did some housekeeping:
A) also corrected the -dev preset and tag descriptions: CI builds them with
INCLUDE_CHROMIUM=false, so they do not include a headless browser. Pointed to--build-arg INCLUDE_CHROMIUM=truefor dev builds that need one.B) our docs example version numbers were stale,
5.0.0and4.1.2. I couldn't just do a drop-in replacement because of the change to the-leantag, so I pointed version examples at 7.0.0, the first release with the superset/lean tag naming, and noted that 6.1.0 and earlier published the minimal image under the plain tag with no-leantag. Also updated UPDATING.md to this effect.C) Updated a stale comment about the
PLAYWRIGHT_REPORTS_AND_THUMBNAILSfeature flag needing to be enabled and what would happen to it "starting in 6.0.0" that was incorrect. #43028 removed both the flag and Selenium support, and it is on the 7.0 branch, so the comments now say Playwright with Chromium is required as of 7.0.0.Kind of a followup to #44100.
FYI, I notice that the tag
masteron Docker Hub is 2 years old, and there's nothing on Docker Hub formaster-lean- I removed the reference tomaster-leanaccordingly but did not look into whether something is broken.