chore: remove unused INCLUDE_FIREFOX build arg and dead screenshot config

[sfirke]

The code changes and PR description are mostly AI-generated. They look good to me. I'm not sure if the UPDATING.md changes are worth it; it's nice to have a record of removal but that's in git history and so if these args were unused then maybe this is just noise? LMK and I can undo that edit.

SUMMARY

Master-only cleanup after #43028 removed Selenium support.

Stacked on #44243, which rewords the INCLUDE_FIREFOX docs line this PR deletes. Until #44243 merges, its changes also show in this diff; this PR's own change is commit 215eb98. I'll update the branch once #44243 merges.

• INCLUDE_FIREFOX build arg: screenshots only ever launch Chromium (superset/utils/webdriver.py calls chromium.launch), so the Playwright Firefox this arg installed is never used. Removed from the Dockerfile, docker-compose.yml, docker-compose-light.yml, docs/admin_docs/installation/docker-builds.mdx and docs/developer_docs/contributing/development-setup.md. INCLUDE_CHROMIUM is unchanged. The docker-builds.mdx change is a one-line hunk that doesn't overlap docs(docker): drop redundant packages from custom image example, bump version numbers #44240.
• EMAIL_PAGE_RENDER_WAIT: nothing has read this config key since chore: remove old alerts and configs keys #19261, and its comment still described Selenium.
• SCREENSHOT_LOCATE_WAIT: nothing has read this key since feat(Reports&Alerts): remove Selenium support, require Playwright #43028 (the Playwright path uses SCREENSHOT_PLAYWRIGHT_DEFAULT_TIMEOUT or the report deadline). Removed the key, the unused _screenshot_locate_wait attribute, its test config entries and the alerts-reports.mdx example line.
• ENABLE_PLAYWRIGHT=false in docker/.env: added in feat: optimize docker-compose up for faster boot time #27953, the same PR that removed the bootstrap step that installed Playwright; nothing reads it.
• UPDATING.md: notes the removals.

Because this removes a build arg and a config key, it's intended for master only. The text-only fixes suitable for 7.0 are in #44244.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

• docker build --check . reports no issues.
• docker compose -f docker-compose.yml config -q and docker compose -f docker-compose-light.yml config -q succeed.
• Build with --build-arg INCLUDE_CHROMIUM=true and confirm Chromium is present under /usr/local/share/playwright-browsers.
• git grep -n -E 'INCLUDE_FIREFOX|EMAIL_PAGE_RENDER_WAIT|SCREENSHOT_LOCATE_WAIT|ENABLE_PLAYWRIGHT' -- ':!docs/*_versioned_docs' ':!CHANGELOG' ':!UPDATING.md' returns nothing.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

---

🤖 Drafted by Claude Code, co-signed by @sfirke.

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	b9e48df
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6ac3cc20d1cf2d0008fff394
😎 Deploy Preview	https://deploy-preview-44245--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.32%. Comparing base (7a2913e) to head (b9e48df).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #44245       +/-   ##
===========================================
+ Coverage   57.31%   82.32%   +25.01%     
===========================================
  Files        2997     2997               
  Lines      185294   185293        -1     
  Branches    42888    42888               
===========================================
+ Hits       106198   152541    +46343     
+ Misses      78056    29992    -48064     
- Partials     1040     2760     +1720     

Flag	Coverage Δ
hive	36.30% <ø> (-0.01%)	⬇️
mysql	55.32% <ø> (?)
postgres	55.33% <ø> (?)
presto	38.17% <ø> (-0.01%)	⬇️
python	86.24% <ø> (+48.02%)	⬆️
sqlite	55.05% <ø> (?)
unit	79.23% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[sadpandajoe]

The inline command fails on the lean image it targets: that stage runs as superset, has no venv pip, and points browser installs at a root-owned path, so playwright install-deps/install chromium fail or the package lands outside /app/.venv; screenshots still raise Playwright is required. Could this use the root + uv pip sequence from the linked Dockerfile example instead?

[sfirke]

Thanks. That command was removed in 9421ce4, after the commit you reviewed. The section no longer gives an inline install. For -lean-based images it links to the example Dockerfile on the Docker Builds page. That example is updated in #44240: it switches to root, installs playwright into /app/.venv with uv pip, then runs playwright install-deps and playwright install chromium before switching back to superset.

---

🤖 Drafted by Claude Code, co-signed by @sfirke.

[sadpandajoe]

This module-level import makes every service loading a shared superset_config.py depend on the optional Playwright extra, even though the guide says only workers need the browser; a lean webserver sharing this config exits on ModuleNotFoundError. Could the example avoid a runtime import, for example with an unannotated or quoted type?

[sfirke]

Good catch, thanks. superset_config.py is loaded by the webserver, beat and workers alike, so a top-level Playwright import breaks every service that doesn't have the browser. I checked it: with Playwright missing, the old example fails with ModuleNotFoundError and the new one imports cleanly. The example now imports BrowserContext (and User, which it used without importing) under TYPE_CHECKING, the same pattern superset/utils/machine_auth.py uses. It also returns the context instead of pass, to match the signature MachineAuthProvider expects. The fix is in #44243 (abb6524) and merged into this branch.

---

🤖 Drafted by Claude Code, co-signed by @sfirke.

[rusackas]

I'll rebase this to clear the conflicts with master, CI's already green. Looks like sadpandajoe's two threads got addressed in-branch already (9421ce4, abb6524), just need marking resolved.

[sfirke]

Argh Claude Code for web screwed up the rebase and force pushed. My bad, I will sort it out later.

[bito-code-review]

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it