fix(matrixify): fan metrics-axis selection into multi-query fields

[sadpandajoe]

SUMMARY

Matrixify's metrics-axis grid generation (generateCellFormData in MatrixifyGridGenerator.ts) only wrote the primary metrics/metric fields for each grid cell. For a multi-query viz type — currently only Mixed Chart (mixed_timeseries), which reads its second query's metric from a metrics_b suffixed field — that suffixed field was never updated per cell, so every cell in the grid showed a different primary series but an identical, frozen secondary series.

This mirrors the dimension-filter case already handled for multi-query viz types (appendMatrixifyFilters, which fans a filter value out to every adhoc_filters_* collection). This change adds the equivalent overrideMatrixifyMetrics, which sets metrics/metric plus every metrics_<suffix> field found on the cell's form data, and calls it instead of writing the fields directly.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Manual repro on a Mixed Chart (mixed_timeseries, birth_names dataset) with a metrics-axis Matrixify grid (rows = SUM(num), SUM(num_boys), SUM(num_girls); query A rendered as bars, query B rendered as a line with a fixed base metric of SUM(num_california)):

Before (bug): the query B line stays frozen at the base chart's SUM(num_california) value in every row, ignoring the row's selected metric.

After (fixed): the query B line now takes on each row's selected metric along with query A, instead of staying pinned to the original value.

TESTING INSTRUCTIONS

• superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridGenerator.test.ts adds a test asserting a metrics-axis selection is applied to every query-specific metrics collection (e.g. metrics_b), not just the primary metrics field.
• Manual: enable MATRIXIFY, create a Mixed Chart (mixed_timeseries), configure a metrics-axis Matrixify grid, and confirm each grid cell's second query series updates per cell instead of staying fixed to the first cell's value.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags: MATRIXIFY
• Changes UI
• Includes DB Migration
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.10%. Comparing base (599026a) to head (b023dde).
⚠️ Report is 132 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #44629      +/-   ##
==========================================
- Coverage   81.10%   81.10%   -0.01%     
==========================================
  Files        2955     2955              
  Lines      178385   178391       +6     
  Branches    41336    41336              
==========================================
+ Hits       144681   144682       +1     
- Misses      30995    31000       +5     
  Partials     2709     2709              

Flag	Coverage Δ
javascript	76.47% <100.00%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[bito-code-review]

Code Review Agent Run #96600b

Actionable Suggestions - 2

• superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridGenerator.ts - 2

  • Unsound double-cast defeats typing · Line 149-149
  • Duplicated key-discovery logic · Line 150-153

Additional Suggestions - 2

• superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridGenerator.ts - 2

  • Shared array reference aliasing · Line 156-156
    Line 156 stores the same `metrics` array reference under `metrics`, every `metrics_*` key, and `metric`. Unlike the sibling `appendMatrixifyFilters`, which builds a fresh array per key, a downstream in-place mutation (sort/push) of one query's metrics would silently affect all queries. Copy per key: `metricsFields[key] = [...metrics];`
  • Dynamic object property assignment flagged · Line 156-156
    Linter flags `metricsFields[key] = metrics` as generic object injection (CWE-1321). Use `Object.defineProperty` to safely set dynamic keys and avoid prototype pollution. Similar issue at line 235.

Review Details

• Files reviewed - 2 · Commit Range: 68a9d88..b7945b8

  • superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridGenerator.test.ts
  • superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridGenerator.ts
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • Eslint (Linter) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers an incremental AI Review.

• /review full - Manually triggers a full AI Review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[bito-code-review]

Unsound double-cast defeats typing

const metricsFields: Record<string, unknown> = formData; double-casts through unknown, disabling type checking for every write to formData. The repo standard requires proper TypeScript types over any-style escape hatches. A typed key list (e.g. Object.keys(formData) into string[]) achieves the same dynamic scan without the unsound cast.

Citations

• Rule Violated: dev-standard.mdc:16

Code Review Run #96600b

---

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

• Yes, avoid them

[bito-code-review]

Duplicated key-discovery logic

overrideMatrixifyMetrics repeats the key-discovery logic of appendMatrixifyFilters (base key plus /^<base>_.+$/ scan over Object.keys), differing only in the per-key mutation. Extracting a shared helper would keep the two query-collection strategies from diverging on future changes.

Code Review Run #96600b

---

Should Bito avoid suggestions like this for future reviews? (Manage Rules)

• Yes, avoid them

[rusackas]

LGTM, nice mirror of appendMatrixifyFilters's structure and a test that actually reproduces the Mixed Chart repro from the issue. One small thing: unlike the sibling function, this reuses the same metrics array reference across every key instead of spreading a fresh copy per key -- probably harmless today, but cheap to close off.

[rusackas]

Suggested change

	metricsFields[key] = metrics;
	metricsFields[key] = [...metrics];

[rusackas]

Your call here @sadpandajoe :) Good to merge otherwise.

[sadpandajoe]

Fixed in b023dde — overrideMatrixifyMetrics now spreads a fresh array per key ([...metrics]) instead of sharing one reference across metrics/metrics_b/etc., matching appendMatrixifyFilters's existing pattern. Added a regression test asserting the per-key arrays aren't the same reference.

[netlify]

✅ Deploy Preview for superset-docs-preview ready!

Name	Link
🔨 Latest commit	b023dde
🔍 Latest deploy log	https://app.netlify.com/projects/superset-docs-preview/deploys/6abc07097511ac0008fc8d11
😎 Deploy Preview	https://deploy-preview-44629--superset-docs-preview.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
🤖 Make changes	Run an agent on this branch

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[bito-code-review]

Code Review Agent Run #57e071

Actionable Suggestions - 0

Review Details

• Files reviewed - 2 · Commit Range: b7945b8..b023dde

  • superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridGenerator.test.ts
  • superset-frontend/packages/superset-ui-core/src/chart/components/Matrixify/MatrixifyGridGenerator.ts
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful
  • Eslint (Linter) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers an incremental AI Review.

• /review full - Manually triggers a full AI Review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by