fix(sql-lab): use function valueGetter for GridTable row numbers

[csbbo]

String expression value getters require CSP unsafe-eval under production Talisman settings. Use a function valueGetter so SQL Lab result row numbers render without relaxing script-src.

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[bito-code-review]

Code Review Agent Run #9262b6

Actionable Suggestions - 0

Review Details

• Files reviewed - 1 · Commit Range: 0ced818..0ced818

  • superset-frontend/src/components/GridTable/index.tsx
• Files skipped - 0
• Tools

  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers a full AI review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[rusackas]

Thanks for this, small fix but a legit one. ag-grid's string-expression valueGetters indeed run through an eval-based parser, so swapping to a plain function is great when running with a strict script-src. The two failing jest shards look like the unrelated SavedQueryList flake, not this change, so I'll get this in once that clears.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.26%. Comparing base (2220f53) to head (420acad).

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #41574       +/-   ##
===========================================
+ Coverage   57.25%   82.26%   +25.01%     
===========================================
  Files        2995     2995               
  Lines      185032   185035        +3     
  Branches    42822    42823        +1     
===========================================
+ Hits       105933   152226    +46293     
+ Misses      78059    30047    -48012     
- Partials     1040     2762     +1722     

Flag	Coverage Δ
javascript	77.88% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[rusackas]

As noted, small fix but a legit one, ag-grid's string-expression valueGetters run through an eval-based parser so swapping to a plain function is the right move under a strict script-src. CI's clean now, approving.

[bito-code-review]

Bito Automatic Review Skipped – PR Already Merged

Bito scheduled an automatic review for this pull request, but the review was skipped because this PR was merged before the review could be run.
No action is needed if you didn't intend to review it. To get a review, you can type /review in a comment and save it