test(cratedb): cover epoch-ms timestamp decoding against a real instance

[rusackas]

SUMMARY

#44720 fixed CrateEngineSpec.fetch_data to decode TIMESTAMP columns via cursor._result["col_types"], working around the fact that crate-python's DBAPI cursor.description always reports type_code=None (confirmed directly by reading crate.client.cursor.Cursor.description: it hardcodes None for every description slot except the column name). The only coverage that landed with that fix was unit tests mocking cursor._result directly — which would never notice if a future crate-python release renamed or restructured that private attribute, since the mock would keep "working" regardless of what the real driver actually does.

This adds a testcontainers case that creates a real table with both TIMESTAMP WITHOUT TIME ZONE and TIMESTAMP WITH TIME ZONE columns (type codes 15 and 11 respectively, per crate.client.converter.DataType — confirmed against the installed crate package), inserts epoch-millisecond values, and runs fetch_data against the real raw DBAPI cursor from a live query, asserting both decode to the correct datetime.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A — test-only change.

TESTING INSTRUCTIONS

CI's Testcontainers workflow runs this against a real crate/crate container (amd64-only, so it won't run under Docker-on-Apple-Silicon locally — see the file's own docstring). To run manually on an x86_64 host with Docker:

pytest tests/testcontainers/db_engine_specs/test_crate.py -m testcontainers -v

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

🤖 Generated with Claude Code

[bito-code-review]

Code Review Agent Run #4a6b99

Actionable Suggestions - 0

Additional Suggestions - 2

• tests/testcontainers/db_engine_specs/test_crate.py - 2

  • Untyped local cursor · Line 141-141
    `cursor` is an untyped local. BITO rule 13153 requires explicit annotations for test-file locals even when inferable; `raw_conn.cursor()` returns Any from the crate DBAPI, so an annotation also documents the type actually expected by `CrateEngineSpec.fetch_data`.
  • Line at E501 length limit · Line 142-142
    Line 142 measures exactly 88 characters, at ruff's configured `line-length = 88` (pyproject.toml) with `E501` in the select list; any later edit to the SQL string pushes it over and fails lint. Wrapping the call keeps headroom.

Review Details

• Files reviewed - 1 · Commit Range: c0d1dc5..c0d1dc5

  • tests/testcontainers/db_engine_specs/test_crate.py
• Files skipped - 0
• Tools

  • MyPy (Static Code Analysis) - ✔︎ Successful
  • Astral Ruff (Static Code Analysis) - ✔︎ Successful
  • Whispers (Secret Scanner) - ✔︎ Successful
  • Detect-secrets (Secret Scanner) - ✔︎ Successful

---

Bito Usage Guide

Commands

Type the following command in the pull request comment and save the comment.

• /review - Manually triggers an incremental AI Review.

• /review full - Manually triggers a full AI Review.

• /pause - Pauses automatic reviews on this pull request.

• /resume - Resumes automatic reviews.

• /resolve - Marks all Bito-posted review comments as resolved.

• /abort - Cancels all in-progress reviews.

Refer to the documentation for additional commands.

Configuration

This repository uses Superset You can customize the agent settings here or contact your Bito workspace admin at evan@preset.io.

Documentation & Help

• Customize agent settings
• Review rules
• General documentation
• FAQ

AI Code Review powered by

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.22%. Comparing base (bc3698b) to head (c0d1dc5).

Additional details and impacted files

@@           Coverage Diff           @@
##           master   #44904   +/-   ##
=======================================
  Coverage   82.22%   82.22%           
=======================================
  Files        2995     2995           
  Lines      184993   184993           
  Branches    42818    42818           
=======================================
  Hits       152107   152107           
  Misses      30127    30127           
  Partials     2759     2759           

Flag	Coverage Δ
hive	36.30% <ø> (ø)
mysql	55.34% <ø> (ø)
postgres	55.35% <ø> (ø)
presto	38.18% <ø> (ø)
python	86.12% <ø> (ø)
sqlite	55.07% <ø> (ø)
unit	79.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[aminghadersohi]

Ran this against a fresh CrateDB container: the test fails when the private _result["col_types"] lookup is renamed, when decoding is removed, and when values are read as epoch seconds. Sub-second precision is covered by the existing unit test.