Skip to content

fix(i18n): parameterize the missing annotation chart error message #44548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
villebro wants to merge 1 commit into from
Closed

fix(i18n): parameterize the missing annotation chart error message #44548

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions superset/common/query_context_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -885,9 +885,11 @@ def get_viz_annotation_data( # noqa: C901
if not (chart := ChartDAO.find_by_id(annotation_layer["value"])):
raise QueryObjectValidationError(
_(
f"""Chart with ID {annotation_layer["value"]} (referenced by
annotation layer '{annotation_layer["name"]}') was not found.
Please verify that the chart exists and is accessible."""
"Chart with ID %(chart_id)s (referenced by annotation layer "
"'%(layer_name)s') was not found. Please verify that the "
"chart exists and is accessible.",
chart_id=annotation_layer["value"],
layer_name=annotation_layer["name"],
)
)

Expand Down
16 changes: 12 additions & 4 deletions superset/translations/ar/LC_MESSAGES/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ msgid ""
msgstr ""
"Project-Id-Version: \n"
"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
"POT-Creation-Date: 2026-09-22 10:58-0700\n"
"POT-Creation-Date: 2026-09-22 17:21-0700\n"
"PO-Revision-Date: 2024-07-14 15:10+0300\n"
"Last-Translator: Abdalrahim G. Fakhouri <abdilra7eem@yahoo.com>\n"
"Language: ar\n"
Expand Down Expand Up @@ -3962,6 +3962,13 @@ msgstr "تعذر حذف المخططات."
msgid "Chart width"
msgstr "عرض المخطط"

#, python-format
msgid ""
"Chart with ID %(chart_id)s (referenced by annotation layer "
"'%(layer_name)s') was not found. Please verify that the chart exists and "
"is accessible."
msgstr ""

msgid "Charts"
msgstr "المخططات"

Expand Down Expand Up @@ -18397,9 +18404,10 @@ msgstr ""

msgid ""
"This update would change the connection's effective destination "
"(host/port, engine parameters, or SSH tunnel endpoint) while reusing the "
"stored credential. Provide the real password (or SSH tunnel credential) "
"to confirm a connection move."
"(host/port, engine parameters, SSH tunnel endpoint, or OAuth2 endpoint "
"URIs) while reusing the stored credential. Provide the real password (or "
"SSH tunnel credential / OAuth2 client secret) to confirm a connection "
"move."
msgstr ""

# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ca, cs, de,
Expand Down
16 changes: 12 additions & 4 deletions superset/translations/ca/LC_MESSAGES/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ msgid ""
msgstr ""
"Project-Id-Version: Superset VERSION\n"
"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
"POT-Creation-Date: 2026-09-22 10:58-0700\n"
"POT-Creation-Date: 2026-09-22 17:21-0700\n"
"PO-Revision-Date: 2025-06-27 12:56+0200\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language: ca\n"
Expand Down Expand Up @@ -3801,6 +3801,13 @@ msgstr "Els gràfics no s'han pogut eliminar."
msgid "Chart width"
msgstr "Amplada del gràfic"

#, python-format
msgid ""
"Chart with ID %(chart_id)s (referenced by annotation layer "
"'%(layer_name)s') was not found. Please verify that the chart exists and "
"is accessible."
msgstr ""

msgid "Charts"
msgstr "Gràfics"

Expand Down Expand Up @@ -17851,9 +17858,10 @@ msgstr ""

msgid ""
"This update would change the connection's effective destination "
"(host/port, engine parameters, or SSH tunnel endpoint) while reusing the "
"stored credential. Provide the real password (or SSH tunnel credential) "
"to confirm a connection move."
"(host/port, engine parameters, SSH tunnel endpoint, or OAuth2 endpoint "
"URIs) while reusing the stored credential. Provide the real password (or "
"SSH tunnel credential / OAuth2 client secret) to confirm a connection "
"move."
msgstr ""

msgid "This username is already taken. Please choose another one."
Expand Down
16 changes: 12 additions & 4 deletions superset/translations/cs/LC_MESSAGES/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ msgid ""
msgstr ""
"Project-Id-Version: Superset VERSION\n"
"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
"POT-Creation-Date: 2026-09-22 10:58-0700\n"
"POT-Creation-Date: 2026-09-22 17:21-0700\n"
"PO-Revision-Date: 2016-05-02 08:49-0700\n"
"Last-Translator: Jan Šmejkal <jan.smejkal@orgis.cz>\n"
"Language: cs\n"
Expand Down Expand Up @@ -3682,6 +3682,13 @@ msgstr "Graf byl uložen, ale se nepodařilo přidat do vybraného panelu."
msgid "Chart width"
msgstr "Šířka grafu"

#, python-format
msgid ""
"Chart with ID %(chart_id)s (referenced by annotation layer "
"'%(layer_name)s') was not found. Please verify that the chart exists and "
"is accessible."
msgstr ""

msgid "Charts"
msgstr "Grafy"

Expand Down Expand Up @@ -17195,9 +17202,10 @@ msgstr ""

msgid ""
"This update would change the connection's effective destination "
"(host/port, engine parameters, or SSH tunnel endpoint) while reusing the "
"stored credential. Provide the real password (or SSH tunnel credential) "
"to confirm a connection move."
"(host/port, engine parameters, SSH tunnel endpoint, or OAuth2 endpoint "
"URIs) while reusing the stored credential. Provide the real password (or "
"SSH tunnel credential / OAuth2 client secret) to confirm a connection "
"move."
msgstr ""

msgid "This username is already taken. Please choose another one."
Expand Down
16 changes: 12 additions & 4 deletions superset/translations/de/LC_MESSAGES/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PROJECT VERSION\n"
"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
"POT-Creation-Date: 2026-09-22 10:58-0700\n"
"POT-Creation-Date: 2026-09-22 17:21-0700\n"
"PO-Revision-Date: 2023-04-07 19:45+0200\n"
"Last-Translator: Holger Bruch <holger.bruch@wattbewerb.de>\n"
"Language: de\n"
Expand Down Expand Up @@ -3614,6 +3614,13 @@ msgstr ""
msgid "Chart width"
msgstr "Diagrammbreite"

#, python-format
msgid ""
"Chart with ID %(chart_id)s (referenced by annotation layer "
"'%(layer_name)s') was not found. Please verify that the chart exists and "
"is accessible."
msgstr ""

msgid "Charts"
msgstr "Diagramme"

Expand Down Expand Up @@ -16830,9 +16837,10 @@ msgstr ""

msgid ""
"This update would change the connection's effective destination "
"(host/port, engine parameters, or SSH tunnel endpoint) while reusing the "
"stored credential. Provide the real password (or SSH tunnel credential) "
"to confirm a connection move."
"(host/port, engine parameters, SSH tunnel endpoint, or OAuth2 endpoint "
"URIs) while reusing the stored credential. Provide the real password (or "
"SSH tunnel credential / OAuth2 client secret) to confirm a connection "
"move."
msgstr ""

msgid "This username is already taken. Please choose another one."
Expand Down
16 changes: 12 additions & 4 deletions superset/translations/en/LC_MESSAGES/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PROJECT VERSION\n"
"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
"POT-Creation-Date: 2026-09-22 10:58-0700\n"
"POT-Creation-Date: 2026-09-22 17:21-0700\n"
"PO-Revision-Date: 2016-05-02 08:49-0700\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language: en\n"
Expand Down Expand Up @@ -3299,6 +3299,13 @@ msgstr ""
msgid "Chart width"
msgstr ""

#, python-format
msgid ""
"Chart with ID %(chart_id)s (referenced by annotation layer "
"'%(layer_name)s') was not found. Please verify that the chart exists and "
"is accessible."
msgstr ""

msgid "Charts"
msgstr ""

Expand Down Expand Up @@ -15410,9 +15417,10 @@ msgstr ""

msgid ""
"This update would change the connection's effective destination "
"(host/port, engine parameters, or SSH tunnel endpoint) while reusing the "
"stored credential. Provide the real password (or SSH tunnel credential) "
"to confirm a connection move."
"(host/port, engine parameters, SSH tunnel endpoint, or OAuth2 endpoint "
"URIs) while reusing the stored credential. Provide the real password (or "
"SSH tunnel credential / OAuth2 client secret) to confirm a connection "
"move."
msgstr ""

msgid "This username is already taken. Please choose another one."
Expand Down
16 changes: 12 additions & 4 deletions superset/translations/es/LC_MESSAGES/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PROJECT VERSION\n"
"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
"POT-Creation-Date: 2026-09-22 10:58-0700\n"
"POT-Creation-Date: 2026-09-22 17:21-0700\n"
"PO-Revision-Date: 2016-05-02 08:49-0700\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language: es\n"
Expand Down Expand Up @@ -3753,6 +3753,13 @@ msgstr "No se han podido eliminar los gráficos."
msgid "Chart width"
msgstr "Anchura del gráfico"

#, python-format
msgid ""
"Chart with ID %(chart_id)s (referenced by annotation layer "
"'%(layer_name)s') was not found. Please verify that the chart exists and "
"is accessible."
msgstr ""

msgid "Charts"
msgstr "Gráficos"

Expand Down Expand Up @@ -17727,9 +17734,10 @@ msgstr ""

msgid ""
"This update would change the connection's effective destination "
"(host/port, engine parameters, or SSH tunnel endpoint) while reusing the "
"stored credential. Provide the real password (or SSH tunnel credential) "
"to confirm a connection move."
"(host/port, engine parameters, SSH tunnel endpoint, or OAuth2 endpoint "
"URIs) while reusing the stored credential. Provide the real password (or "
"SSH tunnel credential / OAuth2 client secret) to confirm a connection "
"move."
msgstr ""

msgid "This username is already taken. Please choose another one."
Expand Down
16 changes: 12 additions & 4 deletions superset/translations/fa/LC_MESSAGES/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ msgid ""
msgstr ""
"Project-Id-Version: Superset VERSION\n"
"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
"POT-Creation-Date: 2026-09-22 10:58-0700\n"
"POT-Creation-Date: 2026-09-22 17:21-0700\n"
"PO-Revision-Date: 2024-10-20 00:07+0330\n"
"Last-Translator: Emad Rad <codewithemad@gmail.com>\n"
"Language: fa\n"
Expand Down Expand Up @@ -3789,6 +3789,13 @@ msgstr "نمودارها نمی‌توانند حذف شوند."
msgid "Chart width"
msgstr "عرض نمودار"

#, python-format
msgid ""
"Chart with ID %(chart_id)s (referenced by annotation layer "
"'%(layer_name)s') was not found. Please verify that the chart exists and "
"is accessible."
msgstr ""

msgid "Charts"
msgstr "نمودارها"

Expand Down Expand Up @@ -17950,9 +17957,10 @@ msgstr ""

msgid ""
"This update would change the connection's effective destination "
"(host/port, engine parameters, or SSH tunnel endpoint) while reusing the "
"stored credential. Provide the real password (or SSH tunnel credential) "
"to confirm a connection move."
"(host/port, engine parameters, SSH tunnel endpoint, or OAuth2 endpoint "
"URIs) while reusing the stored credential. Provide the real password (or "
"SSH tunnel credential / OAuth2 client secret) to confirm a connection "
"move."
msgstr ""

# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ca, cs, de,
Expand Down
16 changes: 12 additions & 4 deletions superset/translations/fi/LC_MESSAGES/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ msgid ""
msgstr ""
"Project-Id-Version: Superset VERSION\n"
"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
"POT-Creation-Date: 2026-09-22 10:58-0700\n"
"POT-Creation-Date: 2026-09-22 17:21-0700\n"
"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n"
"Last-Translator: FULL NAME <EMAIL@ADDRESS>\n"
"Language: fi\n"
Expand Down Expand Up @@ -5910,6 +5910,13 @@ msgstr "Kaavio tallennettiin, mutta sitä ei voitu lisätä valittuun välilehte
msgid "Chart width"
msgstr "Kaavion leveys"

#, python-format
msgid ""
"Chart with ID %(chart_id)s (referenced by annotation layer "
"'%(layer_name)s') was not found. Please verify that the chart exists and "
"is accessible."
msgstr ""

# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ar, ca, cs,
# de, es, fa, fr, it, ja, ko, lv, mi, nl, pl, pt, pt_BR, ru, sk, sl, tr, uk,
# zh, zh_TW]
Expand Down Expand Up @@ -28237,9 +28244,10 @@ msgstr ""

msgid ""
"This update would change the connection's effective destination "
"(host/port, engine parameters, or SSH tunnel endpoint) while reusing the "
"stored credential. Provide the real password (or SSH tunnel credential) "
"to confirm a connection move."
"(host/port, engine parameters, SSH tunnel endpoint, or OAuth2 endpoint "
"URIs) while reusing the stored credential. Provide the real password (or "
"SSH tunnel credential / OAuth2 client secret) to confirm a connection "
"move."
msgstr ""

# Machine-translated via backfill_po.py (claude-sonnet-4-6) [refs: ca, cs, es,
Expand Down
16 changes: 12 additions & 4 deletions superset/translations/fr/LC_MESSAGES/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PROJECT VERSION\n"
"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
"POT-Creation-Date: 2026-09-22 10:58-0700\n"
"POT-Creation-Date: 2026-09-22 17:21-0700\n"
"PO-Revision-Date: 2025-06-26 15:34+0200\n"
"Last-Translator: \n"
"Language: fr\n"
Expand Down Expand Up @@ -3679,6 +3679,13 @@ msgstr ""
msgid "Chart width"
msgstr "Largeur du graphique"

#, python-format
msgid ""
"Chart with ID %(chart_id)s (referenced by annotation layer "
"'%(layer_name)s') was not found. Please verify that the chart exists and "
"is accessible."
msgstr ""

msgid "Charts"
msgstr "Graphiques"

Expand Down Expand Up @@ -17146,9 +17153,10 @@ msgstr ""

msgid ""
"This update would change the connection's effective destination "
"(host/port, engine parameters, or SSH tunnel endpoint) while reusing the "
"stored credential. Provide the real password (or SSH tunnel credential) "
"to confirm a connection move."
"(host/port, engine parameters, SSH tunnel endpoint, or OAuth2 endpoint "
"URIs) while reusing the stored credential. Provide the real password (or "
"SSH tunnel credential / OAuth2 client secret) to confirm a connection "
"move."
msgstr ""

msgid "This username is already taken. Please choose another one."
Expand Down
16 changes: 12 additions & 4 deletions superset/translations/it/LC_MESSAGES/messages.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ msgid ""
msgstr ""
"Project-Id-Version: PROJECT VERSION\n"
"Report-Msgid-Bugs-To: EMAIL@ADDRESS\n"
"POT-Creation-Date: 2026-09-22 10:58-0700\n"
"POT-Creation-Date: 2026-09-22 17:21-0700\n"
"PO-Revision-Date: 2018-02-11 22:26+0200\n"
"Last-Translator: Raffaele Spangaro <raffa@raffaelespangaro.it>\n"
"Language: it\n"
Expand Down Expand Up @@ -4449,6 +4449,13 @@ msgstr "Il grafico è stato salvato ma non può essere aggiunto al tab seleziona
msgid "Chart width"
msgstr "Larghezza grafico"

#, python-format
msgid ""
"Chart with ID %(chart_id)s (referenced by annotation layer "
"'%(layer_name)s') was not found. Please verify that the chart exists and "
"is accessible."
msgstr ""

msgid "Charts"
msgstr "Grafici"

Expand Down Expand Up @@ -21281,9 +21288,10 @@ msgstr ""

msgid ""
"This update would change the connection's effective destination "
"(host/port, engine parameters, or SSH tunnel endpoint) while reusing the "
"stored credential. Provide the real password (or SSH tunnel credential) "
"to confirm a connection move."
"(host/port, engine parameters, SSH tunnel endpoint, or OAuth2 endpoint "
"URIs) while reusing the stored credential. Provide the real password (or "
"SSH tunnel credential / OAuth2 client secret) to confirm a connection "
"move."
msgstr ""

msgid "This username is already taken. Please choose another one."
Expand Down
Loading
Loading