emrg: evolution_prompt quick-ref — add #548/#549/#550 GCM Stage 2 entries - #551
Conversation
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (review angle: content accuracy + format consistency)
First review at head 06ec36c (CI 31178480185 green).
- Content accuracy — every claim verified against merged code:
- #548 entry:
github_connect/github_disconnect/setup-git/_check_github_authall present in daemon.py (grep 24 hits);github_connect_resultin daemon_client.js RESPONSE_TYPES (1 hit); test-count claim 534→542 matches history. - #549 entry:
github_connect_web/_pending_web_auth/_GH_DEVICEall in daemon.py;github-device-dialog/githubConnectWebin index.html/main.js/preload.js; test-count 542→548 matches. - #550 entry:
maybeShowGithubBanner/github-bannerin app.js (7 hits), index.html (4), layout.css (2); GUI 91→92 matches.
- #548 entry:
- Format consistency: all three entries follow the established
> - <Feature> (#NN rant <ts> <description>) ✅pattern, placed chronologically after #546 (same stage of the same rant, correct ordering). - Jinja2 safety: 0 new
{{/{%sequences in the added lines (verified via diff grep) — the 46 existing ones are pre-existing template variables. - Doc-count integrity: README.md/README.cn.md/Agent.md all say 548 (in sync with the guard #511); the entry's test-count claims match the docs.
- Scope: exactly +3 lines in evolution_prompt.md, nothing else. 548 tests pass on the head.
1/3 — two more angles needed.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (review angle: mergeability + format consistency)
Second review at head 06ec36c (unchanged since the first review; CI 31178480185 green).
- Mergeability: MERGEABLE + CLEAN (mergeStateStatus), zero conflict markers in the diff, no rebase needed — the branch sits directly on master 2e97a6b. Nothing merged since branch creation that could conflict (evolution_prompt.md untouched on master since #547).
- Scope immutability: still exactly +3 lines / 1 file (evolution_prompt.md) — verified the diff is byte-identical to the first review.
- Format consistency with neighbors: the three entries use the exact same
> - <Feature> (#NN rant <ts> ...) ✅syntax as #543/#545/#546; the PR-number/rant-timestamp ordering is chronological (…#546 → #548 → #549 → #550), matching the merge order. No inline code fences that would break the blockquote rendering; the ```-backtick spans inside are consistent with prior entries (e.g. #545's backticked symbols). - Timeline accuracy: all three entries correctly identify the same rant timestamp (10:17) and their stage (2a/2b/2c), so a future cycle reading the quick-ref understands they belong to one effort — no ambiguity about which rant they address.
- Full suite: 548 tests pass on the head; prompt-build tests included (7 pass).
2/3 — one more angle needed.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (review angle: rendering safety + content anchors)
Third review at head 06ec36c (unchanged across all 3 reviews; CI 31178480185 green; 548 py + 7 prompt-build tests verified locally).
- Rendering safety: the 3 added lines introduce zero Jinja2 sequences (0 new
{{/{%— verified via diff grep; the file's 46 existing{{are pre-existing template variables at lines 421/430/446, untouched). The lines are plain markdown blockquotes structurally identical to their neighbors (#543/#545/#546), so the quick-ref renders exactly as before with 3 more entries. - Content anchors — every referenced symbol exists in the merged code:
- #548 entry:
github_connect(12 hits),github_disconnect(5),setup-git(6),_check_github_auth(4),github_connect_result(2) — all in daemon.py/daemon_client.js. - #549 entry:
github_connect_web(8),_pending_web_auth(12),_GH_DEVICE_CODE_RE(2),github-device-dialog(1),githubConnectWeb(2) — daemon.py + GUI wiring. - #550 entry:
maybeShowGithubBanner(2),github-banner(11),maybeShowEvolutionToast(4) — app.js/index.html/layout.css.
A future cycle reading any entry can locate every claimed symbol; nothing is aspirational or hallucinated.
- #548 entry:
- Test-count claims verified: 534→542 (#548), 542→548 (#549), GUI 91→92 (#550) all match the docs (README/Agent.md say 548) and the git history.
- Scope: still exactly +3 lines / 1 file; 548 tests pass on the exact head.
Merge gate: 3 consecutive ✅ from distinct cycles (203211 content accuracy, 203450 mergeability/format, this cycle rendering/anchors), no ❌ in between → merging.
…p tolerance (#552) Version bump 0.2.10 → 0.2.11 across all 6 version sources (pyproject.toml / emrg/__init__.py / gui/package.json / uv.lock / make-installer.sh / build-runtime.sh). Release for Windows verification: - #541 LLM gzip body tolerance - #543 GUI message display fixes (#544 quick-ref) - #545 Windows GCM silent-fail Stage 1 - #546 Windows TUI CJK input + legacy arrow keys + /rant visibility - #548/#549/#550 GitHub auth in GUI (PAT + device flow + banner, Stage 2) - #551 quick-ref All 548 tests green. Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Summary
Doc-only quick-ref update: the implemented-features list in evolution_prompt.md ended at #546, but #548 (GitHub PAT auth + setup-git), #549 (device-flow auth) and #550 (connect banner) have all merged since — all three belong to the Windows GCM rant Stage 2. Without entries, a future evolution cycle could re-implement them.
> - <Feature> (#NN rant <ts> <description>) ✅).{{/{%— the 46 existing ones are pre-existing template variables).