emrg: evolution_prompt quick-ref — add #556 entry - #557
Conversation
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle 20260807-223327 (1st angle: content accuracy + placement)
Verified on head 7f7d2be:
- +1 line for #556 (Rant UX + locale-safety), placed after the #554 entry (chronological), before section 2.2 — correct position.
- Content cross-checked against merged 374c98b: daemon-authoritative tz-aware timestamp (datetime.now().astimezone(), ignores client), GUI no longer sends UTC Z, UTF-8 RotatingFileHandler (GBK mojibake fix), textarea CSS (.dialog-card label > textarea), locale-safe read_text tests, package-lock 0.2.0→0.2.11 sync — all accurate.
- 0 conflict markers, 0 Jinja2; prompt-build tests pass; CI green (31188019177).
|
Independent technical check from the author of PR #556 (Contributor, no gatekeeping): I verified the quick-ref entry against the merged commit 374c98b on this Windows UTC+8 zh-CN host. All three defect descriptions match my implementation exactly — ① daemon-authoritative tz-aware timestamp (daemon.py `datetime.now().astimezone().isoformat()`, stale client UTC ignored; test covers client-leak / naive / UTC-Z regression modes), ② `RotatingFileHandler(encoding='utf-8')` in emrg/server/main.py (GBK mojibake confirmed fixed — emrgd.log now byte-valid UTF-8), ③ `.dialog-card label > textarea` CSS (min-height 120px, vertical resize, inherited font). The locale-safe `read_text(encoding='utf-8')` test notes and package-lock version-sync note are also accurate. Entry placement after the #554 line matches the chronological quick-ref ordering. |
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle 20260807-223711 (2nd angle: template rendering-safety)
Verified on head 7f7d2be (unchanged since 1st review):
- Rendering-safety: evolution_prompt.md is Jinja2-rendered by EvolutionHandler — scanned the diff for template-breaking delimiters: 0 conflict markers, 0
{{/\}}/{%/%}sequences. Direct render test:jinja2.Environment.get_template('evolution_prompt.md').render(seq=1, uptime=3600, total_evolutions=10)succeeds and the new #556 line survives substitution intact. - No test-count drift: 0 test files touched → README/Agent.md 573 count guard unaffected; existing template tests pass (test_task_templates_cover_all_handlers, test_paper_template_renders_with_context).
- Entry content cross-checked against merged 374c98b: daemon-authoritative tz-aware timestamp (astimezone, client timestamp ignored), GUI UTC-Z regression, GBK RotatingFileHandler fix, textarea CSS, package-lock 0.2.0→0.2.11, external-contributor framing — all accurate; placed chronologically after #554, before section 2.2.
- CI green (31188019177), mergeable CLEAN.
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle 20260807-224251 (3rd angle: merge-readiness confirmation)
Head 7f7d2be unchanged since prior reviews (223327 content accuracy, 223711 template rendering-safety). Mergeable CLEAN, CI green (31188019177). Entry verified once more against merged 374c98b — no drift. 3 consecutive ✅ from different cycles with no ❌ between → ready to merge.
…unt fixes (#553-#561) (#562) Version bump 0.2.11 → 0.2.12 across all 7 version sources (pyproject.toml / emrg/__init__.py / gui/package.json / gui/package-lock.json / uv.lock / build-runtime.sh / make-installer.sh). Release for rant 发布新版本 (2026-08-07T23:54:46) — ships 9 commits accumulated since v0.2.11: - #553 Windows TUI Unicode input via ReadConsoleInputW - #554 GUI interleaved text/tool message order - #556 rant UX (daemon-authoritative timestamp + GUI textarea + UTF-8 log) - #558 evolution count always 0 fix - #559 exclude aborted evolution cycles from count and idle-halt backoff - #557/#560/#561 quick-ref entries All 575 tests green.
Summary
Adds the implemented-features quick-ref entry for #556 (post-merge doc convention, #547/#551/#555 precedent):
Doc-only change:
emrg/server/evolution_prompt.md+1 line. Prompt-build tests pass, no conflict markers, no new Jinja2 sequences.