emrg: fix GUI file-browser vertical scroll + root collapse (rants 12:46/12:47) - #733
Merged
argszero merged 1 commit intoAug 13, 2026
Conversation
argszero
reviewed
Aug 13, 2026
argszero
left a comment
Owner
There was a problem hiding this comment.
✅ LGTM — cycle
Reviewed the full diff + verified locally:
- CSS:
.result-filesnow hasflex: 1; min-height: 0— correct root cause (flex child withflex: 0 1 autogrows with content sooverflow-y: autonever engages); consistent with.result-list. - JS: root row click handler →
toggleDirwith stopPropagation + reusedensure(root)state; root collapse now matches regular dir rows. - Tests: renderer.smoke 107→109 (both new tests pass locally; full file 109/109 green) + CSS source-level assertion.
- CI: run 31668420499 both test + test-windows PASS.
- Docs: Agent.md npm test counts synced 229→231.
Fixes both host rants 12:46:12 (scroll) and 12:47:18 (root collapse).
argszero
reviewed
Aug 13, 2026
argszero
left a comment
Owner
There was a problem hiding this comment.
✅ LGTM — cycle (1/3)
Reviewed the full diff and verified locally:
- CSS fix is correct:
.result-fileswas a flex child withoutflex:1/min-height:0, so its height grew with content andoverflow-y:autonever triggered (scrollbar slot but no scroll). Now aligned with.result-list— verified the properties are present and the rule retainsoverflow-y:auto. - Root-row fix is faithful:
render()hand-writes the root row and previously never bound a click handler, so the root could not be collapsed. The new handler routes through the existingtoggleDir(expanded Map persistence + icon swap) and shares the samest = ensure(root)state withexpandDir— no duplicated state. - Smoke tests cover both fixes in positive and negative states (CSS props asserted; root default-expanded → click collapses → click re-expands).
npm test: 231 passed / 0 failed. - CI green: test + test-windows both pass (run 31668420499). PR mergeable.
argszero
reviewed
Aug 13, 2026
argszero
left a comment
Owner
There was a problem hiding this comment.
✅ LGTM — cycle (3rd)
Independently re-verified the head this cycle (previously reviewed in an earlier cycle): diff unchanged, CI run 31668420499 test + test-windows PASS, local renderer.smoke 109/109 green. 3 consecutive LGTMs from different cycles — merging.
pm25coder
pushed a commit
to pm25coder/emrg
that referenced
this pull request
Aug 13, 2026
argszero
pushed a commit
that referenced
this pull request
Aug 13, 2026
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes two host-reported GUI workspace file-browser (result-files pane) bugs.