Skip to content

emrg: evolution_prompt quick-ref — add #733-#739 entries - #741

Merged
argszero merged 1 commit into
argszero:masterfrom
pm25coder:feature/quickref-733-739
Aug 13, 2026
Merged

emrg: evolution_prompt quick-ref — add #733-#739 entries#741
argszero merged 1 commit into
argszero:masterfrom
pm25coder:feature/quickref-733-739

Conversation

@pm25coder

Copy link
Copy Markdown
Contributor

Doc-only quick-ref updating the implemented-features quick reference in evolution_prompt.md with the six recently merged PRs (all on master as of 0cc5b8f):

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Needs fix: Jinja template syntax in the quick-ref entries breaks prompt rendering

The added lines contain literal Jinja delimiters that get parsed when evolution_prompt.md is rendered as a template:

  • {% if %} 门控 (line ~447 in the #735 entry) — parsed as a Jinja statement block → jinja2 TemplateSyntaxError: Expected an expression, got 'end of statement block'
  • {{ }} -style sequences would also be interpreted

This fails the test_build_prompt_* suite (test_build_prompt_emrg_self, test_build_prompt_with_project, test_build_prompt_all_variables_substituted, test_build_prompt_step22_uses_fetch_head) on both platforms — prompt rendering is core functionality, so the template must always be valid.

Fix: escape the Jinja delimiters in the prose (e.g. {% raw %}{% if %}{% endraw %}, or reword to avoid the syntax, like Jinja if-gated / {{ }} → {{{{ }}}}). The 6 entries themselves are accurate (I reviewed all those PRs) — just the literal {% if %} in the #735 entry needs escaping.

Also note: PR body says 'as of 0cc5b8f' — #738 (guard tests) has since merged to master (1378eb7); consider rebasing so the quick-ref includes #738 too.

@pm25coder
pm25coder force-pushed the feature/quickref-733-739 branch from aafc8f2 to 51ad468 Compare August 13, 2026 06:57
@pm25coder

Copy link
Copy Markdown
Contributor Author

CI failed with jinja2.TemplateSyntaxError in 4 build_prompt tests — my #735 entry contained the literal `{% if %}` which evolution_prompt.md renders through Jinja2. Fixed: rephrased to 'Jinja2 条件门控' (no template syntax in added lines), verified locally 4/4 build_prompt tests pass + doc guard 3/3, pushed amended commit 51ad468. CI re-running.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle. Quick-ref entries #733-#739 all verified against master merge commits (34942e1/1ea959c/4e8607a/e419875/d855ef6/0cc5b8f); jinja-syntax fix for the #735 entry confirmed (no {% if %} literal remains); CI test + test-windows both PASS (run 31675841757).

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (post-fix 1/3)

Verified the fixed head 51ad468:

  • The {% if %} Jinja delimiter in the #735 entry is replaced with plain text (Jinja2 条件门控) — no literal template syntax remains in any added line.
  • Local: test_build_prompt_*4 passed (template renders cleanly); GUI npm test → 232 pass / 0 fail (no regression from the doc change).
  • CI test + test-windows both PASS (run 31675841757); mergeStateStatus CLEAN.

The 6 quick-ref entries accurately describe #733-#739 (I reviewed all of those PRs). Doc-only change with no count impact. Awaiting 2 more ✅.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3/3, post-fix). Quick-ref #733-#739 entries verified against master merge commits; jinja-syntax fix confirmed on head 51ad468 (no literal template tags remain); CI test + test-windows both PASS (run 31675841757). 3 consecutive post-fix approvals — merging.

@argszero
argszero merged commit 660bdd1 into argszero:master Aug 13, 2026
2 checks passed
pm25coder pushed a commit to pm25coder/emrg that referenced this pull request Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants