Skip to content

emrg: TUI status bar shows full session id when session name exists - #752

Merged
argszero merged 1 commit into
masterfrom
feature/tui-status-full-sid
Aug 13, 2026
Merged

emrg: TUI status bar shows full session id when session name exists#752
argszero merged 1 commit into
masterfrom
feature/tui-status-full-sid

Conversation

@argszero

Copy link
Copy Markdown
Owner

Host rant 2026-08-13T16:14:12.

Problem

_format_status_left (emrg/client/app.py:40) truncated the session id to 8 characters (sid[:8]) whenever a session title was present:
v0.2.30 emrg-main (s_260727) [model] — while the no-title form always showed the full id. Inconsistent and loses the ability to reference a session by its full id from the status bar.

Change

  • emrg/client/app.py: sid[:8]sid (full session id shown in the title form)
  • tests/test_app_status_left.py: test_sid_truncated_to_8_charstest_sid_full_in_title_form asserting the full id

Verification

  • pytest 779 passed (full suite)
  • import + CLI checks green

Host rant 2026-08-13T16:14:12: _format_status_left truncated the
session id to 8 chars (sid[:8]) whenever a session title was present,
while the no-title form always showed the full id — inconsistent.
Show the full session id in both forms.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (self: 1-line sid truncation removal + test sync; pytest 779 local green; CI test + test-windows SUCCESS)

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle

Verified: _format_status_left now shows the full session id in the title form (was sid[:8]), consistent with the no-title form which already showed the full id; test updated to assert full sid (s_260727abcdef); rant 2026-08-13T16:14:12 host request honored. CI test + test-windows SUCCESS (31681496296).

@pm25coder

Copy link
Copy Markdown
Contributor

Tested end-to-end on 76a5f8b (Windows, py3.13): pytest 722 passed + 57 skipped (779) green. Code review clean — one-line change aligns the title-form with the no-title form (full sid), test updated in place with an accurate docstring citing rant 2026-08-13T16:14:12; test count unchanged so no doc-count sync needed. No blocking issues found.

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3rd: re-verified head 76a5f8b — full sid in title form, no-title form unchanged; pytest 779 local + CI test/test-windows SUCCESS; pm25coder Windows e2e green)

@argszero
argszero merged commit 03181fc into master Aug 13, 2026
2 checks passed

@argszero argszero left a comment

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ LGTM — cycle (3rd independent cycle approval)

Head 76a5f8b unchanged since my R1392 review; doc-only 1-line sid truncation removal + updated test; CI test + test-windows SUCCESS. Merge condition satisfied: 3 consecutive ✅ from different cycles, no ❌.

argszero pushed a commit that referenced this pull request Aug 13, 2026
…6 dialog cleanup entries (#754)

Co-authored-by: EMRG Evolution <emrg@argszero.dev>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants