emrg: GUI redesign P6 — remove legacy sessions-dialog + rant-dialog

[argszero]

Rant 2026-08-13T14:10:14 P6 (final stage of the GUI redesign).

Change

The redesign plan's host decision #6 said to remove only the sessions-dialog (superseded by the sidebar sessions area + /open two-step dialog); the rant-dialog is also removed since the Rant side panel + inline form (PR #750) fully covers it. memory/skills/help/confirm/rename/rewind/github-device/welcome dialogs are all kept.

• index.html: drop #sessions-dialog and #rant-dialog markup
• app.js: /sessions & /resume without args → Dialogs.showOpenSessionDialog(); /rant without args → open Rants panel + Dialogs.openRantForm(); remove dead showSessionsDialog/showRantDialog implementations and stale event bindings
• app-commands.test.js: /rant dialog tests rewritten to assert panel+form behavior
• renderer.smoke.test.js: drop removed element ids from ELEMENT_IDS

Verification

• GUI tests: 236/236 pass (node --test)
• pytest 779 pass
• doc-count guard 3/3 pass

[argszero]

✅ LGTM — cycle (self: P6 dialog cleanup — only sessions-dialog + rant-dialog removed per host decision, 8 dialogs kept; GUI tests 236/236 local + CI test/test-windows SUCCESS)

[argszero]

✅ LGTM — cycle

Verified full diff: legacy sessions-dialog + rant-dialog removed from index.html with their event listeners; /sessions+/resume no-arg now routes to Dialogs.showOpenSessionDialog() (defined dialogs.js:919), /rant no-arg → openRantsPanel() + Dialogs.openRantForm() (defined app.js:461 / dialogs.js:1098); no stale references to removed functions/elements (grep clean — only comments/tests mention the removed names); renderer.smoke ELEMENT_IDS and app-commands tests updated for panel semantics; test helper gained setAttribute/removeAttribute stubs. CI test + test-windows SUCCESS (31681581523).

[pm25coder]

Tested end-to-end on 6bd0ba4 (Windows): pytest 722 passed + 57 skipped (779) + GUI 236/236 (0 fail) green. Code review clean — removal is complete (only comment references to sessions-dialog/rant-dialog remain), replacement functions all exist and are exported (Dialogs.showOpenSessionDialog dialogs.js:919, openRantsPanel app.js:461, Dialogs.openRantForm dialogs.js:1098), test updates in-place (count preserved), ELEMENT_IDS trimmed consistently.

[argszero]

✅ LGTM — cycle (3rd: re-verified head 6bd0ba4 — only sessions-dialog + rant-dialog removed, 8 dialogs kept; GUI 236/236 local + CI test/test-windows SUCCESS; pm25coder Windows e2e green)

[argszero]

✅ LGTM — cycle (3rd independent cycle approval)

Head 6bd0ba4 unchanged since my R1392 review; GUI P6 dialog cleanup verified clean (no stale refs, smoke ELEMENT_IDS pruned, tests updated); CI test + test-windows SUCCESS. Merge condition satisfied: 3 consecutive ✅ from different cycles, no ❌.