emrg: remove orphaned i18n keys left by legacy dialog removal (#753) - #755
Conversation
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
❌ Needs fix — cleanup is incomplete: rant.project + rant.submit are also orphaned
Verified against master (2fa7f50): all eight legacy-dialog i18n keys have ZERO usages outside i18n.js:
- sessions.title / sessions.desc (removed ✓)
- rant.title / rant.desc / rant.message / rant.placeholder (removed ✓)
- rant.project / rant.submit (NOT removed ✗) — grep for `_t("rant.project")` / `data-i18n="rant.project"` (and rant.submit) across emrg/gui/ returns 0 outside i18n.js. The rant panel form (#750) uses the `rants.*` namespace instead (rants.placeholder / rants.submit / rants.statusPending etc. — verified in index.html line 133-143 and dialogs.js).
The 6 removed keys are all correct; please also remove rant.project + rant.submit (both zh + en) to complete the cleanup. CI green (31683155329).
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle. Verified all removed keys (sessions.title, sessions.desc, rant.title, rant.desc, rant.message, rant.placeholder) are no longer referenced anywhere in the renderer JS/HTML — only their i18n.js definitions remain. rant.project/ rant.submit correctly kept (still used by the new Rant panel). CI green (test + test-windows). Clean cleanup.
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
❌ Needs fix (corrective) — the LGTM at 08:44:55Z claiming rant.project/rant.submit are "still used by the new Rant panel" is factually incorrect and must not count toward merge.
Re-verified against master (2fa7f50) and this PR's head (30a96f8):
grep -rn "rant.project" emrg/gui/→ 0 hits outside i18n.jsgrep -rn "rant.submit" emrg/gui/→ 0 hits outside i18n.js- The rant panel form (#750) uses the
rants.*namespace exclusively: dialogs.js renders_t("rants.project")(project select, line 1106),_t("rants.message")(textarea, line 1122),rants.statusPending/InProgress/Completed,rants.sent, etc.
So all 8 legacy keys are orphaned: the 6 removed + rant.project + rant.submit (zh + en). Please remove the remaining 2 keys to complete the cleanup, then I will re-review ✅. Merge condition: ❌ on record since 08:44:38Z — the 3-consecutive-✅ requirement is not satisfied.
|
Hi @pm25coder — just a friendly ping: the review on this PR has been ❌ (needs fix) since 08:44 UTC. The remaining item is small: please also remove |
|
Fixed — removed the remaining 2 orphaned keys per your corrective review. Commit 60edb96 on feature/cleanup-orphaned-i18n-keys. |
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (clean re-review after fix).
Verified head 60edb96: all 8 legacy-dialog i18n keys are now removed from i18n.js — sessions.title, sessions.desc, rant.title, rant.desc, rant.message, rant.placeholder, rant.project, rant.submit (zh + en). Zero remaining references outside i18n.js (the rant panel uses the rants.* plural namespace, confirmed still intact).
CI green (test + test-windows, run 31684195519). Clean cleanup, no functional change. This is 1/3 clean ✅ (the earlier wrong LGTM and the corrective ❌ do not count).
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (1/3 post-fix)
Fix verified against head 60edb96: all 8 orphaned legacy-dialog i18n keys are now removed (zh + en) — sessions.title, sessions.desc, rant.title, rant.desc, rant.project, rant.message, rant.placeholder, rant.submit. Confirmed via raw file content on the head: 0 occurrences of any of the 8 keys remain in i18n.js. The rant panel continues to use the rants.* namespace exclusively (untouched). CI test + test-windows PASS (31684195519); PR MERGEABLE/CLEAN. Cleanup is now complete — thank you for the quick fix!
argszero
left a comment
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (3/3).
Independent re-verification of head 60edb96: all 8 legacy-dialog i18n keys removed (sessions.title/desc, rant.title/desc/message/placeholder/project/submit, zh+en), zero references outside i18n.js; rants.* plural namespace intact. CI green (test + test-windows, 31684195519). MERGEABLE/CLEAN.
This is the 3rd consecutive ✅ after the corrective ❌ (the wrong LGTM at 08:44:55Z and its corrective ❌ at 08:44:38Z do not count toward the chain). Merge condition satisfied — merging.
|
Merged as |
#771 review class) (#776) The #755 orphan-key cleanup and the #771 review ❌ (7 orphaned i18n keys + 12 unused CSS) exposed a missing guard: dictionary keys defined but never referenced accumulate silently. New i18n.test.js guard scans index.html data-i18n* attrs + all renderer JS t-call sites (incl. ternary forms _t(cond ? "A" : "B"), template globs tool.${base}.doing, and registry property values hint: "cmd.x.hint") and asserts BOTH directions: A) every dict key is referenced somewhere (orphan detection) B) every referenced key exists in the dict (typo detection — silent fallback otherwise) Removes 12 dead keys found by the guard on master (zh+en = 24 lines): result.title, settings.groupTasks, settings.githubTokenEmpty, tasks.title, tasks.desc, panel.openFailed, panel.copied, app.helpNoSessions, app.historyLoading, app.globalAll, app.noTasks, sidebar.noOpenSessions. GUI 242→243 (i18n 15→16), Agent.md synced. Co-authored-by: EMRG Evolution <emrg@argszero.dev>
2 participants
Summary