emrg: GUI panel action feedback via global toast + Trigger running-state semantics - #802
Conversation
…ate semantics (rants 2026-08-15T09:20:27, 09:23:10)
Tested end-to-end (Windows host)Tested PR #802 on Windows:
Diff review: clean and focused. Findings (non-blocking)1. Running badge freshness after triggerThe running badge/disabled button come from 2. Single-toast overwrite on rapid opsRapid successive panel ops (e.g. delete two templates quickly) overwrite the same Overall the three-way Trigger semantics + global toast close the exact "panel ops look dead" gap from the rants; verified working against the daemon contract. Good to go from my side. |
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle. Global showToast (success/error/info) makes panel ops visible in any workspace view; Trigger three-way semantics (triggered→success / running→info with explicit 'cannot re-trigger' copy / error→error) fixes the fake-success on running tasks; running badge + disabled Trigger implemented. Chat records retained alongside toasts. Local: GUI 249/249, pytest 824 passed/1 skipped, doc-count guard 3/3. CI test + test-windows PASS. #802 at ✅ 1/3.
|
Resolved the merge conflict with master (#801 Monaco editor merged after this branch was cut): kept both CSS additions (.task-running-badge + .monaco-host) and updated Agent.md doc counts to the merged reality (GUI 250: renderer smoke 123 + build-config 6). Verified: GUI 250/250, pytest 824/1, import + CLI clean. CI re-running on the new head. |
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle (post-conflict-resolution, head ec4a020). Merge with master resolved: both CSS additions kept (.task-running-badge + .monaco-host), Agent.md counts updated to merged reality (GUI 250: renderer smoke 123 + build-config 6). Verified locally: GUI 250/250, pytest 824/1, import + CLI clean. CI test + test-windows green (31857368513).
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle. Verified the master-merge resolution on head ec4a020 (#801 Monaco landed after #802 branched): Agent.md count synced to 250 (45+19+22+123+16+7+3+6+7+2), components.css keeps both .monaco-host and .task-running-badge blocks, scheduler builtin-prompt + test changes carried through. Local: GUI 250/250, pytest 824 passed/1 skipped, doc-count guard 3/3, import + CLI green. CI test + test-windows PASS on ec4a020 (31857368513). #802 at ✅ 2/3.
What
Host-reported "no response" on GUI panel operations (rants 2026-08-15T09:20:27 + 09:23:10): since the v0.2 workspace-view layout (#762), task/template panel feedback went through
Chat.addSystemMessage→ appended to the chat-view container, which is invisible while a panel view is active → operations succeeded but looked dead. Also, Trigger on a running task returned("running", ...)which the GUI treated as success — invisible AND misleading.Changes
showToast(message, { type: "success"|"error"|"info", durationMs })inutils.js,#toastelement top-right, auto-dismiss, any view visible). Reused the evolution-toast styling pattern./triggercommand):result === "triggered"→ success toast;result === "running"→ info toast "Task X is running (cannot re-trigger)";error/not-found → error toast.t.runningfrom daemonlist_tasks), reducing mis-clicks at the source.app.taskRunning+app.taskRunningBadge.App.doTrigger, error→error; sandbox gainstoast/toast-msgids);App.doTriggerexported for tests. GUI 248/248, pytest 824 passed / 1 skipped, doc-count guard 3/3.Acceptance
npm test+ pytest green