emrg: GUI task status + next-run countdown (rant 2026-08-15T10:36:39) - #804
Conversation
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
Reviewed the full diff: countdown formatting covers all ranges (≤60s / ≤1h / >1h, negative clamp, decimal floor) with 10-case test; per-second tick uses a deadline snapshot (no row re-render → no flicker/scroll loss); lifecycle is leak-free (stopTaskCountdown on view leave in both switchView paths, idempotent restart, no interval when all tasks running — all covered by tests); i18n zh/en keys added and referenced consistently; Agent.md test counts synced (250→253, renderer smoke 123→126). CI test + test-windows both SUCCESS (run 31860040829).
|
I tested this PR end-to-end on Windows and the implementation checks out. |
argszero
left a comment
There was a problem hiding this comment.
✅ LGTM — cycle
3rd consecutive approval from a different cycle. Full diff reviewed previously (countdown formatting ranges, deadline-snapshot tick, leak-free lifecycle, i18n keys, doc-count 250→253); CI test + test-windows green (31860040829); daemon field next_run_in_seconds verified present (scheduler.py:727).
GUI task management now shows task state and a live next-run countdown (daemon's list_tasks already provides running + next_run_in_seconds + interval; this is a pure display-layer enhancement).
Changes:
运行中(running) badge /待运行pending badge +下次运行 Nscountdown /待调度idle badge; disabled tasks keep the existing已停用hint.43s, ≤1h1m23s, >1h1h05m, negative clamped to 0.Compatible with #802 (running badge + Trigger disable semantics unchanged).